1634813 - When title has multiple lines the panel/popup will look broken

Status: RESOLVED WORKSFORME

(WebExtensions :: Frontend, defect, P5)

Description

[kernp25]

Attachment: f50Ig2Qd1l.png

e.g. The scrollbars are not shown correctly.

From this Bug 1624238.

Comment 1

[kernp25]

Attachment: mI9li89Rj6.png

How it looks like with just one line.

Comment 2

[kernp25]

Attachment: popup.zip

Comment 3

[kernp25]

Attachment: rtcYsm5MkK.png

Comment 4

[kernp25]

My idea is: Instead of showing multiple lines, it should just show one line.
If the line is too long, it should truncate the title and display a tooltip instead.

What do you think?

Comment 5

[kernp25]

It should work like what the menu panel is doing.

Comment 6

[kernp25]

With this bug multiple lines are not really supported in the title, because it will break the menu popup.

Comment 7

[kernp25]

(In reply to kernp25 from comment #5)

It should work like what the menu panel is doing.

I mean, it should work like this.

Comment 8

[:Gijs (he/him)]

Nihanth, can you take a look?

Comment 9

[kernp25]

Attachment: popup.zip

New test add-on.

Comment 10

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to kernp25 from comment #4)

My idea is: Instead of showing multiple lines, it should just show one line.
If the line is too long, it should truncate the title and display a tooltip instead.

What do you think?

I don't agree with this, why not show multiple lines? It's really hard to act on this without a real-world example to illustrate the problem.

I do see the issue with the scrollbars, which should be easy-ish to fix.

Comment 11

[(inactive) Nihanth Subramanya [:nhnt11]]

kernp25, could you clarify how the test add-on attachment illustrates the problem? I see example.com being loaded in the popup. What is the expected result?

Comment 12

[(inactive) Nihanth Subramanya [:nhnt11]]

I also can't reproduce the scrollbar issue. A test case would very much help with this! :)

Comment 13

[kernp25]

Attachment: G54n5ppumW.mp4

Comment 14

[kernp25]

(In reply to Nihanth Subramanya [:nhnt11] from comment #12)

I also can't reproduce the scrollbar issue. A test case would very much help with this! :)

I can reproduce the error with the attached add-on.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1624238

Comment 16

[Rachel Tublitz [:rachel]]

Hi Nihanth, would you mind adding a priority/severity here?

Comment 17

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to kernp25 from comment #14)

(In reply to Nihanth Subramanya [:nhnt11] from comment #12)

I also can't reproduce the scrollbar issue. A test case would very much help with this! :)

I can reproduce the error with the attached add-on.

Are you sure the right add-on is attached? The one that's attached doesn't have a background.js and the panel doesn't show a title.

I can try and tinker with it later.

Meanwhile, marking this P4.

Comment 18

[kernp25]

(In reply to Nihanth Subramanya [:nhnt11] from comment #17)

Are you sure the right add-on is attached?

I tested it with the add-on attached and recorded it in the video above.

The one that's attached doesn't have a background.js and the panel doesn't show a title.

It uses default_title in the manifest. It is not working for you?

Comment 19

[kernp25]

Attachment: manifest.zip

Comment 20

[kernp25]

Attachment: CIyB8EHsG1.png

The scrollbars will be visible when using this css code:

iframe {
  width: 500px;
  height: 500px;
  border: none;
}

But not:

iframe {
  width: 500px;
  height: 600px;
  border: none;
}

Comment 21

[kernp25]

Can you confirm the scrollbar bug?

Comment 22

[kernp25]

Attachment: cHnZII3Qi3.png

If the title has to many lines, the following css code will also not work:

iframe {
  width: 500px;
  height: 500px;
  border: none;
}

Comment 23

[Alex Cornestean]

Hello and sorry for the delay

Using the extension from Comment 19, I am unable to reproduce the scroll bar issue on either the latest Nightly (78.0a1/20200520033931), Beta (77.0b8/20200519220135) or Release (76.0.1/20200507114007). In short, using the extension as is, the scroll bars are visible. This was tested on Windows 10 Pro 64 bit and macOS Catalina 10.15.

However, I did manage to reproduce the issue when modifying the background.js file by adding more lines. Can also confirm Comment 22, that when too many lines are present, the css code does not work. See screenshot 1.

Additionally, on Release, the panel seems to stretch almost the whole width of the screen when opened. On Beta and Nightly this does not occur. See screenshot 2.

Comment 24

[Alex Cornestean]

Attachment: 1 panel with more lines.png

Comment 25

[Alex Cornestean]

Attachment: 2 panel on Release.png

Comment 26

[Alex Cornestean]

Hello Nihanth,

Based on my previous comment (Comment 23), do you think the bug is confirmed and can be set to "New" ? Thanks !

Comment 27

[kernp25]

I think this bug can now be closed. Because it will no longer open the popup in the small panel.