Closed Bug 1634866 Opened 9 months ago Closed 9 months ago

remove StringBundle.jsm in favour of Services.strings

Categories

(Thunderbird :: General, task)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 77.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file)

StringBundle.jsm is redundant. Services.strings.createBundle can be used instead to get a bundle.

https://searchfox.org/comm-central/search?q=new%20Stringbundle(&path=

The jsm has a bit different methods than nsIStringBundle.
https://searchfox.org/mozilla-central/rev/710d6e1015d03343b067b92e6f1f775a0b1cad6f/intl/strres/nsIStringBundle.idl#32-74

Summary: remove StringBundle.jsm in favour of Service.strings → remove StringBundle.jsm in favour of Services.strings
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
See Also: → 1634511
Comment on attachment 9145285 [details] [diff] [review]
bug1634866_rm_stringbundle.patch

Review of attachment 9145285 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=khushil.

::: mailnews/db/gloda/modules/Gloda.jsm
@@ +1962,2 @@
>          } catch (ex) {
> +          console.error(ex);

This is showing lots of errors in the console. It was the same previously but we were not logging anything at that time.
Attachment #9145285 - Flags: review?(khushil324) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/87970e80244c
remove StringBundle.jsm in favour of Services.strings. r=khushil

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 77.0
Regressions: 1636500
You need to log in before you can comment on or make changes to this bug.