1634866 - remove StringBundle.jsm in favour of Services.strings

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

StringBundle.jsm is redundant. Services.strings.createBundle can be used instead to get a bundle.

https://searchfox.org/comm-central/search?q=new%20Stringbundle(&path=

The jsm has a bit different methods than nsIStringBundle.
https://searchfox.org/mozilla-central/rev/710d6e1015d03343b067b92e6f1f775a0b1cad6f/intl/strres/nsIStringBundle.idl#32-74

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1634866_rm_stringbundle.patch

Good try here: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c7896d1d1da254b2a1c30b6e4c85a43d5736b649

Comment 2

[Khushil Mistry [:khushil324]]

Comment on attachment 9145285 [details] [diff] [review]
bug1634866_rm_stringbundle.patch

Review of attachment 9145285 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=khushil.

::: mailnews/db/gloda/modules/Gloda.jsm
@@ +1962,2 @@
>          } catch (ex) {
> +          console.error(ex);

This is showing lots of errors in the console. It was the same previously but we were not logging anything at that time.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/87970e80244c
remove StringBundle.jsm in favour of Services.strings. r=khushil