RNP build fails with gcc compiler
Categories
(Thunderbird :: Build Config, defect, P2)
Tracking
(thunderbird77 fixed)
Tracking | Status | |
---|---|---|
thunderbird77 | --- | fixed |
People
(Reporter: rjl, Assigned: rjl)
References
Details
Attachments
(1 file)
873 bytes,
patch
|
darktrojan
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
make[4]: Entering directory '/NEW-SSD/moz-obj-dir/objdir-tb3/comm/third_party/rnp'
Makefile:18: warning: overriding recipe for target 'librnp.so'
/NEW-SSD/NREF-COMM-CENTRAL/mozilla/config/rules.mk:608: warning: ignoring old recipe for target 'librnp.so'
comm/third_party/rnp/config.h.stub
/NEW-SSD/moz-obj-dir/objdir-tb3/_virtualenvs/init_py3/bin/python -m mozbuild.action.file_generate /NEW-SSD/NREF-COMM-CENTRAL/mozilla/python/mozbuild/mozbuild/action/process_define_files.py process_define_file src/lib/config.h src/lib/.deps/config.h.pp src/lib/.deps/config.h.stub /NEW-SSD/NREF-COMM-CENTRAL/mozilla/comm/third_party/rnp/src/lib/config.h.in
make[4]: Leaving directory '/NEW-SSD/moz-obj-dir/objdir-tb3/comm/third_party/rnp'
Assignee | ||
Comment 1•4 years ago
|
||
The error about overriding the recipe for the librnp.so target should be addressed by bug 1634209
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
This is a build fix for gcc. This flag doesn't exist for gcc, and is the default behavior with clang. It is needed for clang-cl when building for Windows though.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/11757d68b872
Drop use of -fcxx-exceptions flag - makes RNP build with gcc. r=darktrojan
Comment 4•4 years ago
|
||
Comment on attachment 9145889 [details] [diff] [review] Drop use of -fcxx-exceptions flag for gcc Request to uplift OpenPGP improvements to Beta 77 Bug 1 of 9 https://hg.mozilla.org/comm-central/rev/11757d68b872 [Approval Request Comment] Testing completed (on c-c, etc.): yes Risk to taking this patch (and alternatives if risky): only affects openpgp
Comment 5•4 years ago
|
||
Comment on attachment 9145889 [details] [diff] [review] Drop use of -fcxx-exceptions flag for gcc Approved for beta
Comment 6•4 years ago
|
||
Description
•