runtests.sh needs a switch to include optional modules

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Testing Suite
--
enhancement
RESOLVED FIXED
16 years ago
5 years ago

People

(Reporter: Joel Peshkin, Assigned: zach)

Tracking

2.17
Bugzilla 2.18

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
Recently, HEAD has had incidents where checked-in code would not even compile
but was not detected by runtests.sh or tinderbox

This seems to be because runtests.sh cannot presume that everyone has optional
modules installed.   Runtests needs an option (which tinderbox should use) that
assures it that all the optional module dependencies are satisfied and it should
check all of the modules.
(Reporter)

Comment 1

16 years ago
Created attachment 96573 [details] [diff] [review]
Patch to t/Support/Files.pm to selectively exclude files from tests


Patch causes runtests.sh to test files with module dependencies if the module
exists rather than unconditionally ignoring them.
(Reporter)

Comment 2

16 years ago
Created attachment 96601 [details] [diff] [review]
Revised patch - do it neatly
Attachment #96573 - Attachment is obsolete: true

Comment 3

16 years ago
Comment on attachment 96601 [details] [diff] [review]
Revised patch - do it neatly

the patch shows signs of 2 and 4 space indentation, it seems the file also has
8 space indentation :-)

at least make your work consistent (esp w/ modeline), but feel free to fix the
entire file.
Attachment #96601 - Flags: review+
(Reporter)

Comment 4

16 years ago

Checking in t/Support/Files.pm;             
/cvsroot/mozilla/webtools/bugzilla/t/Support/Files.pm,v  <--  Files.pm
new revision: 1.11; previous revision: 1.10
done                    
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Updated

16 years ago
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.