1635054 - Perma newtab SyntaxError: Unexpected token (34:48)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=300363477&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SZ_ySJu8T7K-djpwfbVUcw/runs/0/artifacts/public/logs/live_backing.log

---

This shows up permanently in the 'newtab' tasks which still have an exit status as success. This started with bug 1631838.

[task 2020-05-01T11:13:59.765Z] TEST START | karma
[task 2020-05-01T11:14:58.403Z] ✖ ｢wdm｣: Hash: 823410c8227715dca805
[task 2020-05-01T11:14:58.403Z] Version: webpack 4.41.6
[task 2020-05-01T11:14:58.403Z] Time: 27123ms
[task 2020-05-01T11:14:58.403Z] Built at: 05/01/2020 11:14:28 AM
[task 2020-05-01T11:14:58.403Z] Asset Size Chunks Chunk Names
[task 2020-05-01T11:14:58.403Z] test/unit/unit-entry.js 22.4 MiB 0 [emitted] test/unit/unit-entry
[task 2020-05-01T11:14:58.403Z] Entrypoint test/unit/unit-entry = test/unit/unit-entry.js
[task 2020-05-01T11:14:58.403Z] [0] ./test/unit/unit-entry.js 10.1 KiB {0} [built]
[task 2020-05-01T11:14:58.403Z] [1] (webpack)/buildin/global.js 472 bytes {0} [built]
[task 2020-05-01T11:14:58.403Z] [2] ./test/unit/utils.js 7.07 KiB {0} [built]
[task 2020-05-01T11:14:58.403Z] [3] ./node_modules/enzyme-adapter-react-16/build/index.js 551 bytes {0} [built]
[task 2020-05-01T11:14:58.403Z] [4] ./node_modules/enzyme-adapter-react-16/build/ReactSixteenAdapter.js 109 KiB {0} [built]
[task 2020-05-01T11:14:58.403Z] [40] ./node_modules/enzyme/build/index.js 2.16 KiB {0} [built]
[task 2020-05-01T11:14:58.403Z] [41] ./node_modules/enzyme/build/ReactWrapper.js 139 KiB {0} [built]
[task 2020-05-01T11:14:58.404Z] [442] ./node_modules/enzyme/build/configuration.js 2.2 KiB {0} [built]
[task 2020-05-01T11:14:58.404Z] [444] ./node_modules/enzyme/build/EnzymeAdapter.js 7.37 KiB {0} [built]
[task 2020-05-01T11:14:58.404Z] [467] ./node_modules/enzyme/build/ShallowWrapper.js 210 KiB {0} [built]
[task 2020-05-01T11:14:58.404Z] [468] ./node_modules/enzyme/build/mount.js 1.44 KiB {0} [built]
[task 2020-05-01T11:14:58.404Z] [469] ./node_modules/enzyme/build/shallow.js 1.43 KiB {0} [built]
[task 2020-05-01T11:14:58.404Z] [665] ./test/schemas/pings.js 10.6 KiB {0} [built]
[task 2020-05-01T11:14:58.404Z] [668] ./node_modules/chai-json-schema/index.js 5.98 KiB {0} [built]
[task 2020-05-01T11:14:58.404Z] [671] ./test/unit sync .test.jsx?$ 5.97 KiB {0} [built]
[task 2020-05-01T11:14:58.404Z] + 1008 hidden modules
[task 2020-05-01T11:14:58.404Z]
[task 2020-05-01T11:14:58.404Z] ERROR in ./lib/DownloadsManager.jsm
[task 2020-05-01T11:14:58.404Z] Module build failed (from ./node_modules/istanbul-instrumenter-loader/dist/cjs.js):
[task 2020-05-01T11:14:58.404Z] SyntaxError: Unexpected token (34:48)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$5.raise (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:4454:13)
[task 2020-05-01T11:14:58.404Z] at Parser.pp.unexpected (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:1761:8)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$3.parseExprAtom (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:3750:12)
[task 2020-05-01T11:14:58.404Z] at Parser.parseExprAtom (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:7238:22)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$3.parseExprSubscripts (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:3494:19)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$3.parseMaybeUnary (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:3474:19)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$3.parseExprOps (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:3404:19)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$3.parseMaybeConditional (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:3381:19)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$3.parseMaybeAssign (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:3344:19)
[task 2020-05-01T11:14:58.404Z] at Parser.parseMaybeAssign (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:6474:20)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$3.parseConditional (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:3391:28)
[task 2020-05-01T11:14:58.404Z] at Parser.parseConditional (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:5975:20)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$3.parseMaybeConditional (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:3384:15)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$3.parseMaybeAssign (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:3344:19)
[task 2020-05-01T11:14:58.404Z] at Parser.parseMaybeAssign (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:6474:20)
[task 2020-05-01T11:14:58.404Z] at Parser.pp$1.parseVar (/builds/worker/checkouts/gecko/browser/components/newtab/node_modules/babylon/lib/index.js:2340:24)
[task 2020-05-01T11:14:58.404Z] @ ./test/unit/lib/DownloadsManager.test.js 2:0-60 32:27-43
[task 2020-05-01T11:14:58.404Z] @ ./test/unit sync .test.jsx?$
[task 2020-05-01T11:14:58.404Z] @ ./test/unit/unit-entry.js
[task 2020-05-01T11:14:58.404Z] npm ERR! code ELIFECYCLE
[task 2020-05-01T11:14:58.404Z] npm ERR! errno 1
[task 2020-05-01T11:14:58.404Z] npm ERR! activity-streams@1.14.3 testmc:unit: karma start karma.mc.config.js
[task 2020-05-01T11:14:58.404Z] npm ERR! Exit status 1
[task 2020-05-01T11:14:58.404Z] npm ERR!
[task 2020-05-01T11:14:58.404Z] npm ERR! Failed at the activity-streams@1.14.3 testmc:unit script.
[task 2020-05-01T11:14:58.404Z] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[task 2020-05-01T11:14:58.405Z]
[task 2020-05-01T11:14:58.405Z] npm ERR! A complete log of this run can be found in:
[task 2020-05-01T11:14:58.405Z] npm ERR! /builds/worker/.npm/_logs/2020-05-01T11_14_58_390Z-debug.log
[task 2020-05-01T11:14:58.406Z] TEST START | sasslint
[task 2020-05-01T11:15:00.010Z] { karmaPassed: true, sasslintPassed: true }

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1635054 - stop using ?. operator in newtab download manager code, r?aryx

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba5a792a4bd9
stop using ?. operator in newtab download manager code, r=aryx

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ba5a792a4bd9

Comment 4

[:Gijs (he/him)]

Comment on attachment 9145418 [details]
Bug 1635054 - stop using ?. operator in newtab download manager code, r?aryx

Beta/Release Uplift Approval Request

• User impact if declined: Unclear, definitely broken testing
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: (note: test coverage unknown because of bug 1635090...)
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Avoid using fancy new JS syntax by doing something equivalent that doesn't use new syntax
• String changes made/needed: nope

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9145418 [details]
Bug 1635054 - stop using ?. operator in newtab download manager code, r?aryx

Approved for beta 1, thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eae58b7bc565