Closed Bug 1635064 Opened 4 years ago Closed 4 years ago

New wpt failures in /css/css-images/image-orientation/svg-image-orientation-none.html

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Assigned: heycam)

References

Details

(Whiteboard: [wpt])

Attachments

(1 file)

Bug 1635064 - Make SVG images take image-orientation property into account.
47 bytes, text/x-phabricator-request
Details | Review

Syncing wpt PR 23310 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/css/css-images/image-orientation/svg-image-orientation-none.html: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1633959 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

See Also: → 1634347

This test seems to be demonstrating that we don't respect the styling image-orientation:none on the SVG <image> element. i.e. we use the from-image orientation behavior instead (which is now the default behavior).

Here's a direct link to the testcase:
https://hg.mozilla.org/mozilla-central/raw-file/tip/testing/web-platform/tests/css/css-images/image-orientation/svg-image-orientation-none.html
Reference case:
https://hg.mozilla.org/mozilla-central/raw-file/tip/testing/web-platform/tests/css/css-images/image-orientation/reference/svg-image-orientation-none-ref.html

heycam, do you know if this behavior is intentional/correct? I suspect it's not... Note that https://chromium-review.googlesource.com/c/chromium/src/+/2171064/ (where the test was added) was for a Chromium change that was about adding support for image-orientation:none on SVG images, and the associated bug report has hints about Facebook needing the none behavior to be respected, I think.

(The testcase renders the same, regardless of whether I untick the image-orientation styling in devtools, so we don't seem to be caring about the CSS at all. It looks like this is a regression [before the test was added] -- I see us pass the test in older builds, and fail in newer builds, and I suspect bug 1616411 is the culprit based on my in-progress mozregression run.)

Flags: needinfo?(cam)

Yeah, this test-failure is effectively a regression from bug 1616411. Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f055b35804d7d6f8a5878f21583284708475cf32&tochange=325e655b6024492c976ba22bf2335ad5d2229036

(Based on some quick testing, it looks like we never honored image-orientation on these elements. It's just that our pre-regression-range SVG <image> rendering seemed to match the image-orientation:none behavior, regardless of the actual value of that property, and our new rendering matches the image-orientation:from-image behavior, regardless of the actual value of that property.)

Also notable: the layout.css.image-orientation.initial-from-image pref doesn't seem to make a difference here. (The behavior doesn't change when I toggle that pref off.)

Tentatively rating this as severity S2 due to the possibility of webcompat fallout, per the discussion-with/participation-of Facebook folks on the chromium bug https://bugs.chromium.org/p/chromium/issues/detail?id=1072179 .

Severity: -- → S2

(In reply to Daniel Holbert [:dholbert] from comment #2)

(Based on some quick testing, it looks like we never honored image-orientation on these elements. It's just that our pre-regression-range SVG <image> rendering seemed to match the image-orientation:none behavior, regardless of the actual value of that property, and our new rendering matches the image-orientation:from-image behavior, regardless of the actual value of that property.)

Yes, we should honor image-orientation on SVG images.

Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81bc50969df8
Make SVG images take image-orientation property into account. r=tnikkel

Backed out for webrender failures on image-orientation/svg-image-orientation-aspect-ratio.html

backout: https://hg.mozilla.org/integration/autoland/rev/983684ee2f013effb39d09d965bf7392bd80806c

push: failures firstly appeared on this push https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=092d6f1c299343fe913b590571e4c2c2c3854e86&searchStr=webrender&selectedTaskRun=U-p7HuvMQx2c7GgohtSuoA-0 which led to https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-linux1804-64-qr%2Fdebug-web-platform-tests-reftest-e10s-1%2Cw%28wr1%29&revision=81bc50969df8e6a3ee633248e185cb9ea8cdb3bf

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302550695&repo=autoland&lineNumber=15621

[task 2020-05-16T03:03:21.952Z] 03:03:21 INFO - TEST-START | /css/css-images/image-orientation/svg-image-orientation-aspect-ratio.html
[task 2020-05-16T03:03:21.956Z] 03:03:21 INFO - PID 14186 | 1589598201955 Marionette INFO Testing http://web-platform.test:8000/css/css-images/image-orientation/svg-image-orientation-aspect-ratio.html == http://web-platform.test:8000/css/css-images/image-orientation/reference/svg-image-orientation-aspect-ratio-ref.html
[task 2020-05-16T03:03:21.962Z] 03:03:21 INFO - PID 14231 | [Child 14523, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp, line 3359
[task 2020-05-16T03:03:22.389Z] 03:03:22 INFO - PID 14231 | [Child 14903, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp, line 3359
[task 2020-05-16T03:03:22.795Z] 03:03:22 INFO - PID 14231 | [Child 14841, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/netwerk/base/nsNetUtil.cpp, line 2295
[task 2020-05-16T03:03:22.796Z] 03:03:22 INFO - PID 14231 | [Child 14841, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/checkouts/gecko/caps/ContentPrincipal.cpp, line 398
[task 2020-05-16T03:03:22.796Z] 03:03:22 INFO - PID 14231 | [Child 14841, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/caps/ContentPrincipal.cpp, line 423
[task 2020-05-16T03:03:22.831Z] 03:03:22 INFO - PID 14231 | [Child 14841, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp, line 3359
[task 2020-05-16T03:03:22.859Z] 03:03:22 INFO - PID 14186 | 1589598202853 Marionette WARN [27] http://web-platform.test:8000/css/css-images/image-orientation/reference/svg-image-orientation-aspect-ratio-ref.html overflows viewport (width: 788, height: 604)
[task 2020-05-16T03:03:22.997Z] 03:03:22 INFO - PID 14231 | [Parent 14231, Main Thread] WARNING: NS_ENSURE_TRUE(mDB) failed: file /builds/worker/checkouts/gecko/netwerk/cache/nsDiskCacheDeviceSQL.cpp, line 1279
[task 2020-05-16T03:03:23.001Z] 03:03:23 INFO - PID 14231 | ###!!! [Child][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-05-16T03:03:23.179Z] 03:03:23 INFO - PID 14231 | [Parent 14231, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/js/xpconnect/loader/mozJSComponentLoader.cpp, line 228
[task 2020-05-16T03:03:23.181Z] 03:03:23 INFO - PID 14231 | [Parent 14231, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/js/xpconnect/loader/mozJSComponentLoader.cpp, line 255
[task 2020-05-16T03:03:23.264Z] 03:03:23 INFO - PID 14186 | 1589598203258 Marionette WARN [27] http://web-platform.test:8000/css/css-images/image-orientation/svg-image-orientation-aspect-ratio.html overflows viewport (width: 788, height: 604)
[task 2020-05-16T03:03:23.515Z] 03:03:23 INFO - PID 14186 | 1589598203500 Marionette INFO Allowed 5534-6147 pixels different, maximum difference per channel 17-20
[task 2020-05-16T03:03:23.645Z] 03:03:23 INFO - TEST-UNEXPECTED-FAIL | /css/css-images/image-orientation/svg-image-orientation-aspect-ratio.html | Testing http://web-platform.test:8000/css/css-images/image-orientation/svg-image-orientation-aspect-ratio.html == http://web-platform.test:8000/css/css-images/image-orientation/reference/svg-image-orientation-aspect-ratio-ref.html
[task 2020-05-16T03:03:23.645Z] 03:03:23 INFO - Found 1193 pixels different, maximum difference per channel 2

Flags: needinfo?(cam)
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b60450442a14
Make SVG images take image-orientation property into account. r=tnikkel

https://hg.mozilla.org/mozilla-central/rev/b60450442a14

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Blocks: 1634347
See Also: 1634347 →
Assignee: wptsync → cam
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: