1635068 - remove dead pref extensions.screenshots.upload-disabled and unused function isUploadDisabled()

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement)

Description

[Anna]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

The Screenshot extension's upload functionality was removed a while ago and extensions.screenshots.upload-disabled is now a dead pref. [1]

The custom experimental API function isUploadDisabled() isn't used anymore either and can also get removed. [2]

Good first bug

[1] https://searchfox.org/mozilla-central/search?q=upload-disabled
[2] https://searchfox.org/mozilla-central/search?q=isUploadDisabled

Comment 1

[Alin Ilea, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

Hi,

I will move this enhancement over to a component so developers can take a look over it. If this is not the correct component please feel free to change it to an appropriate one.

Thanks for your suggestion.

Comment 2

[Anna]

Attachment: 1635068.patch

This is my 1st patch. Not sure what to select under flags etc.

If I did something wrong please let me know. Also don't know how to proceed now... any help is appreciated.

Comment 3

[Falguni Islam]

Attachment: Bug 1635068: fix removed dead pref extensions.screenshots.upload-disabled and unused function isUploadDisabled()

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5121e6b3b60
fix removed dead pref extensions.screenshots.upload-disabled and unused function isUploadDisabled() r=emalysz

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d5121e6b3b60