Closed Bug 1635136 Opened 6 years ago Closed 6 years ago

add a --push-to-try option

Categories

(Testing :: mozperftest, enhancement)

Version 3
enhancement

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: tarek, Assigned: tarek)

Details

Attachments

(1 file)

This option will push all arguments for mach perftest in the try commit in a json file
and let the CI unwrap it for mach perftest.

This will be useful to run any perftest on bitbar

we can use push_to_try() from tools/tryselect/push.py and put all the options in try_task_config.json

and passing perftest parameters using the v2 schema https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/decision.py#141

this will use a task that will rebuild the mach perftest call

Summary: add a --run-on-try option → add a --push-to-try option

CLI examples

push on g5:

./mach perftest --android --android-app-name org.mozilla.fennec_aurora --perfherder-metrics processLaunchToNavStart --android-install-apk fennec_aurora --hooks testing/performance/hooks_applink.py --push-to-try testing/performance/perftest_applink.js

push on pixel 2:

./mach perftest --android --android-app-name org.mozilla.fennec_aurora --perfherder-metrics processLaunchToNavStart --android-install-apk fennec_aurora --hooks testing/performance/hooks_applink.py --push-to-try  --try-platform p2 testing/performance/perftest_applink.js

Work in progress

try run nhttps://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=6a21cdde831fdc8bb207c0af14088cf0adaa9b94

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78

Looks like this line always evaluates to True in a boolean context, because is_linux becomes 'linux-bitbar' when worker['os'] != 'linux'

In other words it should be:
is_linux = worker['os'] == 'linux' or worker['os'] == 'linux-bitbar'

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: