Closed Bug 1635208 Opened 4 years ago Closed 4 years ago

Unit test fails when updating waitForElement to waitFor in graphs_view_test

Categories

(Tree Management :: Perfherder, defect, P3)

Product:
Tree Management
Component:
Perfherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: camd, Unassigned)

Details

The React Testing Library command waitForElement has been deprecated and upgraded to waitFor. Most cases work straight through. But while updating, a single case in the file graphs_view_test.jsx fails when changed. So I left that case as-is and will need to be updated by the test owners.

I had already spent more time on this upgrade than I'd like due to issues in the Filtering_test.jsx file, so sorry to leave this to you. :/

Hi Ionut, would you be able to look into changing the usage of waitForElement for waitFor in graphs_view_test.jsx? It seems that upgrading the test libraries is not as easy as with the rest of the tests.

Flags: needinfo?(igoldan)

I should mention, this update is blocked by me upgrading React Testing Library. I'm currently hitting some errors with the upgrade. So I'll chime back in here when I have that merged.

That PR has now been merged. So this bug is unblocked and can be addressed.

Priority: -- → P3
Flags: needinfo?(igoldan)

This was resolved in Bug 1651374

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.