RFE: Move the XLFD parser to gfx/src/x11shared

RESOLVED INACTIVE

Status

()

Core
XUL
P3
enhancement
RESOLVED INACTIVE
16 years ago
2 days ago

People

(Reporter: Roland Mainz, Assigned: Roland Mainz)

Tracking

Trunk
mozilla1.2beta
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

16 years ago
RFE: We should seperate the XLFD parser to the seperate source file+header in
gfx/src/x11shared
(Assignee)

Comment 1

16 years ago
Taking myself...
Assignee: jaggernaut → Roland.Mainz

Comment 2

16 years ago
Roland: could you describe in a bit more detail exactly what parts you think
should be moved?

I also assume this is separate from the nsRenderingContextXXX.cpp code.
(Assignee)

Comment 3

16 years ago
I was thinking about the part from
http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsFontMetricsGTK.cpp#3920 up
to http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsFontMetricsGTK.cpp#4043
- the code is mainly identical between GTK+ and Xlib code.
(Assignee)

Comment 4

16 years ago
nsFontGTK::IsEmptyFont() can be moved to that new source file, too...
(Assignee)

Comment 5

16 years ago
bstell:
Can I pull the patches from the following bugs into this bug, please (e.g. doing
some general cleanup and getting rid of two longstanding issues):
- bug 117440 ("remove usages of DEBUG_PRINTF in favor of NS_ASSERTION/NS...")
- bug 117877 ("x11 font banning checkin (bug 104075) increased startup t...")
?

Comment 6

16 years ago
is the plan to get several small things r=/sr='d at once?
(Assignee)

Comment 7

16 years ago
Brian Stell wrote:
> is the plan to get several small things r=/sr='d at once?

Yes, doing this with small patches would be a pain since the patches would
overlap - and then I won't be able to finish this before the 1.2beta freeze (Oct
8) - which means more rotten patches in bugzilla... ;-(

Comment 8

16 years ago
merging in bug 117440 "... DEBUG_PRINTF" seems okay.

Will bug 117877 "x11 font banning checkin increased startup time" be 
problematic due to performance issues?
(Assignee)

Comment 9

16 years ago
Brian Stell wrote:
> Will bug 117877 "x11 font banning checkin increased startup time" be 
> problematic due to performance issues?

No, since I only want to integrate the nsFontMetrics*.cpp code changes and not
the prefs.
Once this patch is "in" we can try turning "on" the prefs again as part of bug
117877 and see if the performance improvements are sufficient enougth or not...

Comment 10

16 years ago
ok
(Assignee)

Comment 11

16 years ago
Brian Stell wrote:
> ok

Thanks!
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.2beta

Updated

7 years ago
QA Contact: jrgmorrison → xptoolkit.widgets

Comment 12

2 days ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.