RFE: We should seperate the XLFD parser to the seperate source file+header in gfx/src/x11shared
Assignee: jaggernaut → Roland.Mainz
Roland: could you describe in a bit more detail exactly what parts you think should be moved? I also assume this is separate from the nsRenderingContextXXX.cpp code.
I was thinking about the part from http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsFontMetricsGTK.cpp#3920 up to http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsFontMetricsGTK.cpp#4043 - the code is mainly identical between GTK+ and Xlib code.
nsFontGTK::IsEmptyFont() can be moved to that new source file, too...
bstell: Can I pull the patches from the following bugs into this bug, please (e.g. doing some general cleanup and getting rid of two longstanding issues): - bug 117440 ("remove usages of DEBUG_PRINTF in favor of NS_ASSERTION/NS...") - bug 117877 ("x11 font banning checkin (bug 104075) increased startup t...") ?
is the plan to get several small things r=/sr='d at once?
Brian Stell wrote: > is the plan to get several small things r=/sr='d at once? Yes, doing this with small patches would be a pain since the patches would overlap - and then I won't be able to finish this before the 1.2beta freeze (Oct 8) - which means more rotten patches in bugzilla... ;-(
merging in bug 117440 "... DEBUG_PRINTF" seems okay. Will bug 117877 "x11 font banning checkin increased startup time" be problematic due to performance issues?
Brian Stell wrote: > Will bug 117877 "x11 font banning checkin increased startup time" be > problematic due to performance issues? No, since I only want to integrate the nsFontMetrics*.cpp code changes and not the prefs. Once this patch is "in" we can try turning "on" the prefs again as part of bug 117877 and see if the performance improvements are sufficient enougth or not...
Brian Stell wrote: > ok Thanks!
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.2beta
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.