Closed Bug 163537 Opened 22 years ago Closed 15 years ago

Zooming for images

Categories

(SeaMonkey :: UI Design, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: damir.perisa, Assigned: mcsmurf)

References

Details

(Keywords: access)

Attachments

(1 file)

when images are displayed directly (no HTML-code), where should be an option to
zoom it (zoom-to-fit, zoom-1:1, zoom-in, zoom-out) --- this is usefull when you
are displaying too large images (weather-satellite-photos, high-res-files in
medicine and science ... )
As a temp fix, you could always put the following as a bookmark and place it in
the personal toolbar with the name z+ or something:

javascript:(function(){ function zoomImage(image, amt) { if(image.initialHeight
== null) { /* avoid losing height information due to integer rounding while
zooming out */ image.initialHeight = image.height; image.initialWidth =
image.width; image.scalingFactor = 1; } image.scalingFactor *= amt; image.width
= image.scalingFactor * image.initialWidth; image.height = image.scalingFactor *
image.initialHeight; } for (i=0; i<document.images.length; ++i)
zoomImage(document.images[i], 2); })();

z- would be:

javascript:(function(){ function zoomImage(image, amt) { if(image.initialHeight
== null) { /* avoid losing height information due to integer rounding while
zooming out */ image.initialHeight = image.height; image.initialWidth =
image.width; image.scalingFactor = 1; } image.scalingFactor *= amt; image.width
= image.scalingFactor * image.initialWidth; image.height = image.scalingFactor *
image.initialHeight; } for (i=0; i<document.images.length; ++i)
zoomImage(document.images[i], .5); })();

Bookmarklets from the web. Just change the scaling factor in the last statement
to customize.

This works with both images in HTML and with raw images.
at least for a optional zoom-to-fit we have a bug.....
Whiteboard: DUPME
I think comment #2 is saying there is existing bug report covering this bug but
fails to give a bug number, i looked but did not find a specific bug for image
zooming.  removing DUPME.  

http://bugzilla.mozilla.org/show_bug.cgi?id=4821
Full Zoom of course includes image zooming.  Does this count as blocker, or does
this dend on it as a meta bug, or is viewing images on their own a seperate
matter?  I am not sure.  

I am surprised that there is not an Zoom only images bug report blocking it.  
I would very much like Zooming for images.  

On smaller screens many standalone images (like desktop wallpapers for example)
are to big to be seen all at once.  
Internet Explorer 6 has a way to shrink images to fit the avialable window
(useful but the inteface is not great, IE does not have view Image built in like
Mozilla).  

There are various javascript based workarounds for this, 
http://www.squarefree.com/bookmarklets/pagedata.html
http://www.bookmarklets.com/tools/look/index.phtml#zmfrst
i took the above bookmarlet and modified it to zoom by N rather than by a %
http://matrix.netsoc.tcd.ie/~horkana/dev/javascript/
i need to clean up zoom to height/width bookmarklets and put them up too.  
you can do lots of things by wrapping images in page and then setting the <img>
height and width tags to various different values.  
it would be really nice tho' when you have selected 'view image' to then be able 
to Zoom to various levels such 50%, 100%, 200%, Fit to Width, Fit to Height, etc
i guess i need to learn how to hack my javascipt with some XUL and install them
into the context menu ...

Moving to NEW adding my vote.  
adding keyword access

Just to be completely clear, I assume we are all talking about flat
raster/bitmap images and not SVG or other vector images.  I want to make that
distintion.  
If the original reporter could add specificy more exaclty what they think is
necessary that would be great.  

It would be really brilliant to leverage all the great existing functionality of
Mozilla to make it into a better image viewer.  
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: access
Hardware: PC → All
Whiteboard: DUPME
Related: bug 73322
http://www.microsoft.com/windows/ie/using/howto/customizing/autoresize.asp

Just reading an article on Salon about how great Mozilla is and the whole notion
of it being a platform.  

Microsoft call their new image feature 'autoresize'

the reason i mention it here as i believe someone will inevitably post a
duplicate request with differnt wording and refer to 'autoresize' and it is such
a vague description it might be hard to know what the f it means.  

Umm, wait a minute ... looking at bug 73322 as mentioned in the previous commetn
i am seriously wondering if this report it differnt enough to merit a seperate
bug report.  Unless the reporter has something in mind i dont thinks it is
differnt enough.  

I also dont know why the Zoom options cannot just go in the context menu, but i
will save the details for bug 73322

I am going to mark this as a duplicate of bug 73322 but if you tell me how this
is different i will reopen it.  



*** This bug has been marked as a duplicate of 73322 ***
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
reporter back from holidays --- here my answers to the questions in the comments
--- sorry for the late retourn:

comment 1: great idea, i tried it some minutes ago - works fine, but i think
this feature should not be in the Personal-Toolbar or Bookmarks-Folder
At least we (I) have a workaround for zooming (and the bookmarklets are a
subject i have to have a look on) - thx

comment 3: yes, i'm speaking about ("flat") images and now SVG (Scalable Vector
Graphics) --- and i agree with you about the last sentence

comment 5: "autoresize", the new feature in IE6 has a good point of view and a
bad one - the comments about autoresize can be read not only in the comments of
bug 73322 --- i'm not against this feature, as it is really nice for some
situations - but in this bug i mentioned the basic zooming actions (zoom to fit,
zoom 1:1 (as saved image), zoom-in, zoom-out) :: bug 73322 / autoresize is
nothing else then doing the "zoom-to-fit" automaticly, when the image is too big
to be shown => REOPEN BUG
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
in comment 3 i was asked to specify what i think is a good solution:

features for zooming:

- zoom-to-fit: this is usefull to show the whole image - a part of the feature
"autoresize" that is commented in bug 73322

- zoom-(1:1): this is usefull to show the real size of an image - it works
perfect when the resolution of the display is setup correctly (GIMP,
Corel-PhotoPaint ... have it in their preferences - don't know how mozilla
handle it over imglib) - when the resolution is setup correctly, also distances
of the image on the display are right /// this is not "zoom to 100%" (only when
you scan something in the same resolution your display is, then it is 100%) -
ask if you want a detailed explaination, my english is not perfect

- zoom-in: - zoom-out: these are the two features that do not exist in IE, but
are - so think i - of big importance: e.g. when you want to show a image in the
double size (2:1) or in the half size (1:2), but i suggest to have a part in the
preferences to specify the factor of zooming (1/2, 1/3 ...) because some people
may want to zoom only a "third" in/out (4:3) and not "half" (2:1) - ask when you
do not understand what i mean

now how to implement this in mozilla:

1* the idea with the menu at the right-mouse-button is not bad - maybe we may
have a item [Zoom] with the subitems [to fit], [to 1:1], [IN] and [OUT] - where
the factor for IN and OUT can be specified in the preferences

2* or with shortkeys: when the mouse is over a image, [=]=[to fit], [1]=[to
1:1], [+]=[IN] and [-]=[OUT]

3** or/and with small buttons in the tab-title (in the right corner, just after
the filename of the image) like this:
   _______/ [ ]image724892489248924.png [Fit][1:1][+][-] \_____

4** in the menu [View], there should be a subitem [Image Zoom] with subitems:
[to fit]
[8:1]
[4:1]
[3:1]
[2:1]
[1:1]
[1:2]
[1:3]
[1:4]
[1:8]

*) for standalone images and inline-images (in html ...)
**) only for standalone images possible (isn't it?)
-> XP APPS
Assignee: Matti → sgehani
Status: REOPENED → NEW
Component: Browser-General → XP Apps
QA Contact: asa → paw
Have tried the javascript Personal Toolbar workround for zooming all images on 
the page and it works well. I think the developeers should consider this a 
built in feature. I still feel there is a case for adding zoom in and zoom out 
to the right click context menu when clicking on images as you do not 
necessarily want to zoom all fifty or more images on certain pages! The old MS 
Web Accessories for IE5 (no longer available) had this amongst other extra 
context menu features and having switched to Mozilla it is one thing I really 
miss! 
I would like to be able to easily zoom selected graphics as my eysight varies
during the day at odd times.  

When looking at some technical diagrams, the text in the image is sometimes
difficult or unreadable, so I need to be able to enlarge the image.  

Obviously I can't use text zoom to enlarge text in images (with the possible
excption of SVG images?)!
*** Bug 245042 has been marked as a duplicate of this bug. ***
changing component in accordance with
http://bugzilla.mozilla.org/show_bug.cgi?id=245042#c1
Assignee: samir_bugzilla → guifeatures
Component: XP Apps → XP Apps: GUI Features
QA Contact: pawyskoczka
Product: Core → Mozilla Application Suite
Image Zoom works in Mozilla/Seamonkey: https://addons.mozilla.org/firefox/139/
Filter "spam" on "guifeatures-nobody-20080610".
Assignee: guifeatures → nobody
QA Contact: guifeatures
w00t! 
betas for 2.0 have full page Zooming

Had been playing with Firefox and was almost tempted to abandon good old Seamonkey  :O  

Minor problem thouugh, if you choose "View Image" and are viewing just an image with no HTML the Zoom option is disabled.  

This issue is so close to finally being fixed I'm really excited.  
Flags: blocking-seamonkey2?
Target Milestone: --- → seamonkey2.0
Component: XP Apps: GUI Features → UI Design
Should be an easy fix, removing the observes="isImage" part from http://mxr.mozilla.org/comm-central/source/suite/browser/navigatorOverlay.xul#414
Attached patch PatchSplinter Review
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Comment on attachment 372454 [details] [diff] [review]
Patch

Easy to review.
Attachment #372454 - Flags: review?(neil)
Comment on attachment 372454 [details] [diff] [review]
Patch

What about when browser.zoom.full is false?

[Automatic image resizing likes to reset full zoom to 100%...]
Comment on attachment 372454 [details] [diff] [review]
Patch

*sigh*
Attachment #372454 - Flags: review?(neil)
I thought about forcing full zoom mode when viewing an image but that would make it hard to restore the zoom after leaving the image, so I guess you have to move the zoom menu disabling into updateViewMenu (but be aware that this is shared code so that there may not be an isImage broadcaster).
Attachment #372454 - Flags: review+
Comment on attachment 372454 [details] [diff] [review]
Patch

Actually, I've changed my mind. Text zoom when a browser is viewing an image is an edge case, so file a separate bug for that.
Pushed to comm-central, changeset 0e393879e25d.
Will file follow-up bug.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago15 years ago
Resolution: --- → FIXED
Flags: blocking-seamonkey2?
Target Milestone: seamonkey2.0 → seamonkey2.0b1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: