Make mozilla::ipc::PrincipalInfoToPrincipal always return Result<nsCOMPtr<nsIPrincipal>, nsresult>
Categories
(Core :: General, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: ssengupta, Assigned: ssengupta)
References
Details
Attachments
(1 file, 17 obsolete files)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta-
|
Details | Review |
mozilla::ipc::PrincipalInfoToPrincipal should return nsresult in all situations, where it cannot return nsCOMPtr<nsIPrincipal>. Therefore MOZ_CRASH is not called in any error situation in this method. The caller can decide how to best go forward.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D73838
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D73839
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D73840
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D73841
Assignee | ||
Comment 6•5 years ago
|
||
Depends on D73842
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D73843
Assignee | ||
Comment 8•5 years ago
|
||
Depends on D73844
Assignee | ||
Comment 9•5 years ago
|
||
Depends on D73845
Assignee | ||
Comment 10•5 years ago
|
||
Depends on D73846
Assignee | ||
Comment 11•5 years ago
|
||
Depends on D73847
Assignee | ||
Comment 12•5 years ago
|
||
Depends on D73848
Assignee | ||
Comment 13•5 years ago
|
||
Depends on D73849
Assignee | ||
Comment 14•5 years ago
|
||
Depends on D73850
Assignee | ||
Comment 15•5 years ago
|
||
Depends on D73851
Assignee | ||
Comment 16•5 years ago
|
||
Depends on D73852
Assignee | ||
Comment 17•5 years ago
|
||
Depends on D73853
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 18•5 years ago
|
||
Comment 19•4 years ago
|
||
Comment 20•4 years ago
|
||
bugherder |
Assignee | ||
Comment 21•4 years ago
|
||
Comment on attachment 9145813 [details]
Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb
Beta/Release Uplift Approval Request
- User impact if declined: Exposure to frequent crashes related to missing origin when returning nsIPrincipal pointer from PrincipalInfo data structure. This method is used throughout various components of DOM, Netwerk, and more.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): This change is not very risky, because it returns mozilla::Result. Therefore there is no nullptr return to be handled. However, the PrincipalInfoToPrincipal method is used in a lot of critical pieces of code, which makes changes to this method inherently risky to an extent.
- String changes made/needed:
Comment 22•4 years ago
|
||
Subhamoy, are you requesting uplift because we could have more crashes in 77 than in 76 without this patch?
Comment 23•4 years ago
|
||
Comment on attachment 9145813 [details]
Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb
Too big of a refactoring to uplift late in the beta cycle for the potential benefit, let's let it ride the train and see in beta 78 if the volume of crashes gfixed by these patches goes down, thanks for the context given on slack!
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Description
•