1635416 - Search Configuration - Bing favicon is not consistent over distribution builds

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect)

Description

[Petruta Horea [:phorea]]

Attachment: differentBingIcon.png

Tested on Windows10

baseline:

76.0RC en-US build configured with acer distribution - Bing is set as default search engine 
region: US

modern-configuration:

Nightly en-US build 20200505
region: US
simulated distribution ini code: acer-001 and acer-002

Actual results:
The default search engine - Bing - has a has a different icon in 76.0RC build compared with the one in the Nightly build. The icon in Nightly is the same with the one in tab bar when visiting bing.com.

Expected results:
The same icon should be used in all builds / distributions.

Comment 1

[Petruta Horea [:phorea]]

According to bug 1272692, the Bing favicon is right on Nightly, so it may need update only on github. If that's the case, this will no longer block bug 1630980.

Comment 2

[Petruta Horea [:phorea]]

Attachment: SeznamDifferences.png

I've noticed differences also for Seznam distribution. Please let me know if I should file this separately.

modern-configuration
Nightly 77.0a1 -cs build 20200505
region: CZ
simulated distribution ini code: seznam

This time, the Nightly build has a different icon from the site's favicon, but that should be correct accordingly to bug 1419117.

Comment 3

[Mark Banner (:standard8)]

I've just had a chat with Mike Kaply and he says the ones in nightly are the correct ones - the ones for the distributions are out of date.

Generally the icon should match the favicon of the site.

Petruta, for Seznam, nightly matches their site for me, but your comment implies it is different?

Otherwise I think we can resolve this as wfm.

Comment 4

[Adrian Florinescu [:aflorinescu]]

(In reply to Mark Banner (:standard8) from comment #3)

I've just had a chat with Mike Kaply and he says the ones in nightly are the correct ones - the ones for the distributions are out of date.

In regards to this note, we are a bit unaware to how the partner builds are actually done. In the case of the reported bing favicon being outdated, that is not a concern? (somehow the partner build would get the right favicon at build time?)

Comment 5

[Mark Banner (:standard8)]

(In reply to Adrian Florinescu [:aflorinescu] from comment #4)

(In reply to Mark Banner (:standard8) from comment #3)

I've just had a chat with Mike Kaply and he says the ones in nightly are the correct ones - the ones for the distributions are out of date.

In regards to this note, we are a bit unaware to how the partner builds are actually done. In the case of the reported bing favicon being outdated, that is not a concern? (somehow the partner build would get the right favicon at build time?)

The distribution builds in the github repo are out of date wrt to the sites. However, at this stage it is easier just to press ahead than to go back and change them for what should be no more than one more release cycle.

Comment 6

[Petruta Horea [:phorea]]

Attachment: seznamFavIcon.png

After more digging, here's what I've noticed: seznam.cz has the same icon used for Nightly search engine, however, when a search is performed in address bar, the results shown are from search.seznam.cz which has a different favicon (the old one).

Comment 7

[Petruta Horea [:phorea]]

(In reply to Mark Banner (:standard8) from comment #3)

Otherwise I think we can resolve this as wfm.

Agree, marking accordingly.