1635489 - Collect telemetry on corrupt or otherwise inaccessible databases.

Status: RESOLVED FIXED

(Toolkit :: Storage, task, P3)

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1635489: Add telemetry on the status of sqlite database accesses.

Comment 2

[Dave Townsend [:mossop]]

Attachment: data collection request

Note that I will likely be submitting similar requests for other kinds of data stores in the profile.

Comment 3

[Chris H-C :chutten]

Comment on attachment 9145952 [details]
data collection request

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 82.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :mossop is responsible for renewing or removing the collection before it expires in Firefox 82.

---
Result: datareview+

Comment 4

[Dave Townsend [:mossop]]

Attachment: Data collection renewal request

Comment 5

[Chris H-C :chutten]

Comment on attachment 9169186 [details]
Data collection renewal request

The short-form isn't suitable for making expiring collections permanent, so I'll take this instead as a patch to the original review.

The only outstanding question is who will own this collection in perpetuity? I assume it's you, Mossop.

If so (or if you identify the person so responsible), the original data-review+ stands.

Comment 6

[Dave Townsend [:mossop]]

I'd say me and Marco own the telemetry collected here.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af815754d58a
Add telemetry on the status of sqlite database accesses. r=mak

Comment 8

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=TGRurkYGRja0m-ovKyWTow.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-android-em-7.0-x86_64%2Fdebug-geckoview-xpcshell-e10s%2Cx1&revision=3aecd9a7137e1cf9f5fa2cd1dae5453008f3e4d6

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312644115&repo=autoland&lineNumber=3276

Backout: https://hg.mozilla.org/integration/autoland/rev/c02934a6103229b5b6e4b265cbb610b1f7c510aa

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/996954d1f980
Add telemetry on the status of sqlite database accesses. r=mak

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/996954d1f980