1635523 - Twitter secondary search deprecation

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Christopher Arnold]

Please remove the secondary search option for Twitter in Firefox 78. Our partnership with Twitter has concluded its term.

Comment 1

[Francesco Lodolo [:flod]]

This doesn't seem like a bug that should be public?

Comment 2

[Mark Banner (:standard8)]

Adrian, I have put up the removal of Twitter on prod-preview. I think we probably only need a few checks to ensure that changing the configuration from having Twitter to not having Twitter still works, and that it isn't displayed anywhere it shouldn't be.

That above is for modern config.

For legacy config, we'll land patches to disable it (just in case we have to revert).

Overall, plan of landing is:

1. Modern config via remote settings.
2. Legacy config into mozilla-central.
3. Once modern & legacy have landed: remove the twitter extension files.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1635523 - Remove twitter from the legacy configuration. r?daleharvey!

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1635523 - Remove now unused twitter files and pull in latest config. r?daleharvey!

Depends on D76908

Comment 5

[Adrian Florinescu [:aflorinescu]]

Verification was completed, detils in bug 1641238 . Ping :standard8.

Comment 6

[Mark Banner (:standard8)]

Thanks, I've asked Mike Connor to approve, I've also triggered landing of the changes to the legacy configuration.

Adding leave-open to remind me to land the tests once things update.

Comment 7

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/b11a4969f535171c1e416fa79ef2626f766fd542
https://hg.mozilla.org/mozilla-central/rev/b11a4969f535

Comment 8

[Mark Banner (:standard8)]

Reopening per leave-open, as we need to land the tests as well.

Comment 9

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/89c202fdb156926eef9e8379b0ab116437b48891
https://hg.mozilla.org/mozilla-central/rev/89c202fdb156

Comment 10

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

In addition to comment 1 from bug 1641238 we verified Fx 79.0a1(2020-06-03) and Fx 78.0b2(legacy builds). The OS and region coverage is as follows:

Windows 7 x64

"lt",
"ms",
"my",
"oc",

Windows 10 x64

"en-US",
"ach",
"an",
"ca",

Ubuntu 18.04

"es-ES",
"ga-IE",
"ia",
"ka",

Mac 10.13.6

"sl",
"tl",
"tr",
"ja-JP"

Additional to checking if the twitter is removed we have also did a bit of exploratory on various scenarios with twitter default & default engine in legacy, then switched to modern configuration, ensuring the correct default gets set after removal.

Comment 11

[Mark Banner (:standard8)]

Connor says he's happy to open this.