Closed Bug 1635523 Opened 5 months ago Closed 4 months ago

Twitter secondary search deprecation

Categories

(Firefox :: Search, task, P1)

78 Branch
task
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 78
Iteration:
78.2 - May 18 - May 31
Tracking Status
firefox77 --- unaffected
firefox78 --- fixed

People

(Reporter: carnold, Assigned: standard8)

References

Details

Attachments

(2 files)

Please remove the secondary search option for Twitter in Firefox 78. Our partnership with Twitter has concluded its term.

This doesn't seem like a bug that should be public?

Group: mozilla-employee-confidential
Severity: -- → N/A
Iteration: --- → 78.2 - May 18 - May 31
Points: --- → 2
Priority: -- → P1
Assignee: nobody → standard8
Status: NEW → ASSIGNED

Adrian, I have put up the removal of Twitter on prod-preview. I think we probably only need a few checks to ensure that changing the configuration from having Twitter to not having Twitter still works, and that it isn't displayed anywhere it shouldn't be.

That above is for modern config.

For legacy config, we'll land patches to disable it (just in case we have to revert).

Overall, plan of landing is:

  1. Modern config via remote settings.
  2. Legacy config into mozilla-central.
  3. Once modern & legacy have landed: remove the twitter extension files.
Flags: needinfo?(aflorinescu)
Flags: needinfo?(aflorinescu)

Verification was completed, detils in bug 1641238 . Ping :standard8.

Flags: needinfo?(standard8)

Thanks, I've asked Mike Connor to approve, I've also triggered landing of the changes to the legacy configuration.

Adding leave-open to remind me to land the tests once things update.

Flags: needinfo?(standard8)
Keywords: leave-open

Reopening per leave-open, as we need to land the tests as well.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #9151862 - Attachment description: Bug 1635523 - Remove now unused twitter files. r?daleharvey! → Bug 1635523 - Remove now unused twitter files and pull in latest config. r?daleharvey!
Status: REOPENED → RESOLVED
Closed: 4 months ago4 months ago
Keywords: leave-open
Resolution: --- → FIXED

In addition to comment 1 from bug 1641238 we verified Fx 79.0a1(2020-06-03) and Fx 78.0b2(legacy builds). The OS and region coverage is as follows:

Windows 7 x64

"lt",
"ms",
"my",
"oc",

Windows 10 x64

"en-US",
"ach",
"an",
"ca",

Ubuntu 18.04

"es-ES",
"ga-IE",
"ia",
"ka",

Mac 10.13.6

"sl",
"tl",
"tr",
"ja-JP"

Additional to checking if the twitter is removed we have also did a bit of exploratory on various scenarios with twitter default & default engine in legacy, then switched to modern configuration, ensuring the correct default gets set after removal.

Connor says he's happy to open this.

Group: mozilla-employee-confidential
You need to log in before you can comment on or make changes to this bug.