Closed Bug 163570 Opened 22 years ago Closed 22 years ago

Search.pm calls time2str which is not found in the file

Categories

(Bugzilla :: Query/Bug List, defect)

2.17
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: jussi, Assigned: jussi)

References

()

Details

Attachments

(1 file, 1 obsolete file)

When using a '10d' type date in the 'were changed between' field, bugzilla
reports the following error:

Undefined subroutine &Bugzilla::Search::time2str called at Bugzilla/Search.pm
line 835.

I could not duplicate this in http://landfill.bugzilla.org/bugzilla-tip/query.cgi.
Attached patch patch (obsolete) — Splinter Review
Fixes the error by adding &:: in front of the two time2str calls.
Comment on attachment 95948 [details] [diff] [review]
patch

|use Date::Format;| at the top (just under the package line) instead
Attachment #95948 - Flags: review-
Attached patch patch v2Splinter Review
Add the use statement instead of &::
Attachment #95948 - Attachment is obsolete: true
Hmm. While this is definately the right thing to do, I can't reproduce this.

What perl version are you running?
I'm running perl 5.6.1.
Hmm - so do I

Can you give a url which would trigger this, that I can copy-and-paste to my
local installation? (ie something without products/components selected)
In my installation, the query in url field causes the error.
Attachment #95956 - Flags: review+
Comment on attachment 95956 [details] [diff] [review]
patch v2

Hmm. No idea why I couldn't reproduce this.

r=bbaetz x2, I'll check it in under the Bugzilla::Util include (for style
reasons)
-> patch author
Assignee: endico → jussi
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: