1635828 - Isolate HSTS per first-party when privacy.partition.network_state is set to true

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1635828 - Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 1 - new pref, r?timhuang

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1635828 - Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 1 - implementation, r?timhuang

Depends on D74076

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1635828 - Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 2 - tests, r?timhuang

Depends on D74077

Comment 4

[Phabricator Automation]

Comment on attachment 9146207 [details]
Bug 1635828 - Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 1 - new pref, r?timhuang

Revision D74076 was moved to bug 1639247. Setting attachment 9146207 [details] to obsolete.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:baku, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Andrea Marchesini [:baku]]

We are not going to land these patches.

Comment 7

[Andrea Marchesini [:baku]]

Attachment: Bug 1635828 - Reset window.name when the new document is cross-origin - tests, r?annevk

Comment 8

[Andrea Marchesini [:baku]]

Attachment: Bug 1635828 - Reset window.name when the new document is cross-origin, r?smaug

Comment 9

[Phabricator Automation]

Comment on attachment 9159703 [details]
Bug 1635828 - Reset window.name when the new document is cross-origin - tests, r?annevk

Revision D81335 was moved to bug 444222. Setting attachment 9159703 [details] to obsolete.

Comment 10

[Phabricator Automation]

Comment on attachment 9159745 [details]
Bug 1635828 - Reset window.name when the new document is cross-origin, r?smaug

Revision D81361 was moved to bug 444222. Setting attachment 9159745 [details] to obsolete.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c410710919ab
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 1 - implementation, r=timhuang,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/52be379dbb20
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 2 - tests, r=timhuang

Comment 12

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_sts_privatebrowsing_perwindowpb.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/5ea69c2dd5703e1be732c115c70098f03bde908f
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309328195&repo=autoland&lineNumber=5986

Also failures on test_ext_webrequest_hsts.html - https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309324769&repo=autoland&lineNumber=22605

Comment 13

[Narcis Beleuzu [:NarcisB]]

Also bc failure on

1. browser_star_hsts.js - https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309328739&repo=autoland&lineNumber=8086
2. browser_staticPartition_HSTS.js -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309328474&repo=autoland&lineNumber=1847

Comment 14

[Andrea Marchesini [:baku]]

Attachment: Bug 1635828 - Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 3 - partition key, r?xeonchen

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/075697c4a0d4
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 1 - implementation, r=timhuang,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/6dacf81142c4
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 2 - tests, r=timhuang
https://hg.mozilla.org/integration/autoland/rev/c0822aa74d29
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 3 - partition key, r=xeonchen

Comment 16

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=c0822aa74d294e081dced1460726fde82aeea936&failure_classification_id=2

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309736284&repo=autoland&lineNumber=6042
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309736463&repo=autoland&lineNumber=12173
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309738311&repo=autoland&lineNumber=49720

Backout: https://hg.mozilla.org/integration/autoland/rev/c23fb5fe682e3c08848adf2546ebef0db69b367e

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c47f9b403ae
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 1 - implementation, r=timhuang,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/d232cb3c4779
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 2 - tests, r=timhuang
https://hg.mozilla.org/integration/autoland/rev/30c58380f352
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 3 - partition key, r=xeonchen

Comment 18

[Alexandru Michis [:malexandru]]

Backed out 3 changesets (Bug 1635828) for causing bc failures in browser_tab_detach_restore.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7efcafbf21975b1f2886cd7efad411f7de73b398

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=30c58380f352f1776deb8bc7efced440aa190b50&selectedTaskRun=KvrEs9AQRF-rChR1topE8A.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311973515&repo=autoland&lineNumber=8749

Comment 19

[Tim Huang[:timhuang]]

Attachment: Bug 1635828 - Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 4 - Fix tests. r?baku

We need to specifiy the partition key for correctly clean-up HSTS data
if network partition is enabled. Without this, some tests could be
affected by HSTS.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ec4db600c1f
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 1 - implementation, r=timhuang,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/1bfeca8427e6
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 2 - tests, r=timhuang
https://hg.mozilla.org/integration/autoland/rev/04a8f6581dde
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 3 - partition key, r=xeonchen
https://hg.mozilla.org/integration/autoland/rev/1f93614c3fde
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 4 - Fix tests. r=baku

Comment 21

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8ec4db600c1f
https://hg.mozilla.org/mozilla-central/rev/1bfeca8427e6
https://hg.mozilla.org/mozilla-central/rev/04a8f6581dde
https://hg.mozilla.org/mozilla-central/rev/1f93614c3fde

Comment 22

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddd533d95b74
Backed out 4 changesets for causing Bug 1666083

Comment 23

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This got backed out to prevent beta bustages tomorrow morning (bug 1666083).

Comment 24

[mac198442]

Looks like just an "#ifdef MOZ_DIAGNOSTIC_ASSERT_ENABLED" is required.

Comment 25

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Merged to central: https://hg.mozilla.org/mozilla-central/rev/ddd533d95b74

Comment 26

[Tim Huang[:timhuang]]

Attachment: Bug 1635828 - Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 5 - Fix the build bustage issue. r?baku

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db4721fc361e
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 1 - implementation, r=timhuang,necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/d3870c6215ea
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 2 - tests, r=timhuang
https://hg.mozilla.org/integration/autoland/rev/0c05c887a898
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 3 - partition key, r=xeonchen
https://hg.mozilla.org/integration/autoland/rev/11c0130d00a4
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 4 - Fix tests. r=baku
https://hg.mozilla.org/integration/autoland/rev/ab039ff38bea
Isolate HSTS per first-party when privacy.partition.network_state is set to true - part 5 - Fix the build bustage issue. r=dimi

Comment 28

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/db4721fc361e
https://hg.mozilla.org/mozilla-central/rev/d3870c6215ea
https://hg.mozilla.org/mozilla-central/rev/0c05c887a898
https://hg.mozilla.org/mozilla-central/rev/11c0130d00a4
https://hg.mozilla.org/mozilla-central/rev/ab039ff38bea