1635925 - Add test for runtime.connect / onConnect from/to moz-extension:-frame

Status: RESOLVED FIXED

(WebExtensions :: General, task, P1)

Description

[Rob Wu [:robwu]]

We have test coverage for runtime.connect/onConnect to and from different moz-extension documents (and even from content scripts in a frame), but none for runtime.connect from/to extension pages that are embedded in a moz-extension:-document.

We should add such a test. The expectation is that extensions can reach other moz-extension:-contexts with runtime.connect.

Note that we do already have a similar test for the runtime.sendMessage / onMessage APIs in test_ext_runtime_sendMessage_self.js: from parent to frame and from frame to parent.

There is also an unspecified/untested case of what would/should happen of a (currently unprivileged) moz-extension: page in a web page. Currently such documents do not receive events. If we host the document in the extension process, then we could consider increasing the privilege level of the available permissions. If that happens, then runtime.onConnect (and runtime.onMessage) would be triggered in response to runtime.connect (respectively runtime.sendMessage) calls.

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Bug 1635925 - Add test for connect/onConnect to and from extension iframes

Comment 2

[Tomislav Jovanovic :zombie]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c34f5729419107cb4bf9c107f3784881e7c3168d

Comment 3

[Tomislav Jovanovic :zombie]

Followup test https://phabricator.services.mozilla.com/D74573#2270671

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32ec0376e307
Add test for connect/onConnect to and from extension iframes r=robwu

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/32ec0376e307

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:zombie, maybe it's time to close this bug?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:zombie, maybe it's time to close this bug?

Comment 8

[Tomislav Jovanovic :zombie]

Attachment: Bug 1635925 - Add test for moz-extension iframe messaging r?robwu

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e81bb1b5c7b
Add test for moz-extension iframe messaging r=robwu

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6e81bb1b5c7b