Closed Bug 1635941 Opened 4 years ago Closed 4 years ago

Drop debug printf in DOMIntersectionObserver.cpp ("UpdateIntersectionObservation" messages on the console)

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

It was accidentally added. At that time I added it for bug 1400971. :/

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78

Set release status flags based on info from the regressing bug 1634943

Even with Nightly 52cf30bf74473e78c0baf8c4d6055910f67a0a37 ("first release with" according to hg) I see constant console spam, filling my 16GB /tmp within minutes. There are several more printfs here.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Drop debug printf in DOMIntersectionObserver.cpp → Drop debug printf in DOMIntersectionObserver.cpp ("UpdateIntersectionObservation" messages on the console)

Looks like hiro removed logging from QueueIntersectionObserverEntry, but mistakenly left behind the (identical-code) logging in UpdateIntersectionObservation, which is here:
https://searchfox.org/mozilla-central/rev/dc4560dcaafd79375b9411fdbbaaebb0a59a93ac/dom/base/Element.cpp#3813

gah, thank you Daniel!

Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ead8f0367372
followup: Drop some more debugging printfs. r=boris
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: