1635956 - Use Shmems instead of SharedMemory in WebGL remoting

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, task, P1)

Description

[David Parks [:handyman]]

IpdlQueue is still set up to create and send SharedMemory objects instead of Shmems, which won't work on Linux as FileDescriptors must be handled by the socket. This bug will change the operations in QueueParamTraits to use Shmem.

Comment 1

[David Parks [:handyman]]

Attachment: Bug 1635956: Part 1 - Refactor WebGL QueueParamTraits to use Push/PopShmem r=jgilbert!

The old style of using SharedMemory objects was fine for Windows but was incompatible with Mac and Linux because the objects were not sent to the remote process with the proper socket scheme. This meant that shared memory could not be read by the destination process. Shmems are capable of this on all platforms so we use them instead.

Comment 2

[David Parks [:handyman]]

Attachment: Bug 1635956: Part 2 - Implement Shmem functionality in WebGL IpdlQueue r=jgilbert!

Implements LookupSharedMemory and AllocShmem in IpdlQueue (and fixes a few minor build issues).

Depends on D74972

Comment 3

[David Parks [:handyman]]

Attachment: Bug 1635956: Part 3 - Implement Shmem functionality in WebGL ProducerConsumerQueue r=jgilbert!

Implements LookupSharedMemory and AllocShmem in ProducerConsumerQueue (and fixes a few minor build issues).

Depends on D74973

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jgilbert, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jgilbert, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/864c987c5aa8
Part 1 - Refactor WebGL QueueParamTraits to use Push/PopShmem r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/f004c5cbfce3
Part 2 - Implement Shmem functionality in WebGL IpdlQueue r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/801f886cf1b6
Part 3 - Implement Shmem functionality in WebGL ProducerConsumerQueue r=jgilbert

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/864c987c5aa8
https://hg.mozilla.org/mozilla-central/rev/f004c5cbfce3
https://hg.mozilla.org/mozilla-central/rev/801f886cf1b6