Closed Bug 1635957 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 23418 - Use the backdrop filter's clip for synthetic effects and layers

Categories

(Core :: Web Painting, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23418 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23418
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Use the backdrop filter's clip for synthetic effects and layers

Previously for a synthetic effect and the associated synthesized mask
layer, we used the clip that introduce the synthetic effect as their
clip state, causing incorrect clipping of backdrop filters.

Now use the clip of the backdrop filter for synthetic effects and
layers to avoid the problem.

ClipPaintPropertyNode rounded_clip
ClipPaintPropertyNode rect_clip

EffectPaintPropertyNode backdrop_filter clip=rect_clip

The cc effect tree is like
mask_isolation (backdrop filter moved here)
/
mask_effect node_for_backdrop_filter

When we create the cc node for backdrop_filter, we find that there is
an ancestor clip (rounded_clip) needs a synthetic effect and synthesized
mask, so create mask_isolation and mask_effect nodes and a mask clip
layer. To let the backdrop filter access the correct backdrop, we move
the backdrop filter up to mask_isolation, requiring that mask_isolation
to use the backdrop_filter's clip (rect_clip) instead of the clip
(rounded_clip) that introduces the synthetic effect, to ensure the
backdrop filter is correctly clipped. This in turn requires that
mask_effect and the mask layer also use rect_clip as their clip state to
ensure proper clip hierarchy.

Bug: 1077137
Change-Id: Ib9c3cc7e8db5b1b261b3a758f2fb6680e0f5ab1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183198
Commit-Queue: Xianzhu Wang \<wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers \<pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766158}

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/filter-effects/backdrop-filter-clip-rounded-clip.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a41195e5501
[wpt PR 23418] - Use the backdrop filter's clip for synthetic effects and layers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/50d4da5c6410
[wpt PR 23418] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c27e5fdfd1d
[wpt PR 23418] - Use the backdrop filter's clip for synthetic effects and layers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d26a6402ab4f
[wpt PR 23418] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.