[wpt-sync] Sync PR 23455 - Fix "auto" outline in elements with padding and inline descendants
Categories
(Core :: Layout, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
(Depends on 1 open bug, Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 23455 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/23455
Details from upstream follow.
Manuel Rego Casasnovas <rego@igalia.com> wrote:
Fix "auto" outline in elements with padding and inline descendants
This patches fixes the problem described in crbug.com/1048070
related with elements with padding and inline-block or inline descendants.
For these elements the outline was being wrongly painted
as we were computing some offsets twice.This patch adds a test covering lots of cases and combinations:
external/wpt/css/css-ui/outline-027.htmlApart fromt that it also adds a test for outline elements
and floating descendants with margins and paddings:
external/wpt/css/css-ui/outline-028.html
This one is unrelated to this patch and was working fine too,
but in our previous attempt to fix this issue we got a regression
related to floated elements (see crbug.com/1057576).Last this is also including the test that was written
for the original patch that ended up being reverted
https://chromium-review.googlesource.com/c/chromium/src/+/2038296:
external/wpt/css/css-ui/outline-with-padding-001.htmlBUG=1048070
TEST=external/wpt/css/css-ui/outline-027.html
TEST=external/wpt/css/css-ui/outline-028.html
TEST=external/wpt/css/css-ui/outline-with-padding-001.htmlChange-Id: Ie7cf667b91deafa351af7915e69a066c5a665334
Reviewed-on: https://chromium-review.googlesource.com/2187311
WPT-Export-Revision: 7d7486529c6f7235beef938cab8d99369da0eeb4
Assignee | ||
Updated•9 months ago
|
Assignee | ||
Comment 1•9 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fdc23f0295caab30454e338092ceec7662180fa
Assignee | ||
Comment 2•9 months ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 3 tests
Status Summary
Firefox
FAIL: 3
Chrome
PASS: 1
FAIL: 2
Safari
PASS: 2
FAIL: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/css/css-ui/outline-028.html: FAIL
New Tests That Don't Pass
/css/css-ui/outline-027.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-ui/outline-with-padding-001.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-ui/outline-028.html: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebe454a8398d [wpt PR 23455] - Fix "auto" outline in elements with padding and inline descendants, a=testonly https://hg.mozilla.org/integration/autoland/rev/f2f9303db917 [wpt PR 23455] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2b44957eb00 [wpt PR 23455] - Fix "auto" outline in elements with padding and inline descendants, a=testonly https://hg.mozilla.org/integration/autoland/rev/a44e5764ffe9 [wpt PR 23455] - Update wpt metadata, a=testonly
Comment 5•8 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a2b44957eb00
https://hg.mozilla.org/mozilla-central/rev/a44e5764ffe9
Description
•