Closed Bug 16361 Opened 25 years ago Closed 25 years ago

[DOGFOOD][MLK] nsEditor::CreateNode() and nsEditor::RemoveAttribute() leak

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: mozilla, Assigned: mozeditor)

References

(
URL
)

Details

(Whiteboard: [PDT+]MAJOR LEAK) 

Lots of function in nsEditor, such as:

nsEditor::CreateNode() [around line #893]
nsEditor::SetAttribute() [around line #846]
nsEditor::RemoveAttribute() [around line #879]
(and perhaps more, I didn't check them all)

appear to potentially leak a ChangeAttributeTxn.  Please fix these leaks...
either add NS_RELEASE()s for each ChangeAttributeTxn or switch to using
nsCOMPtrs, as appropriate.

[Note: leak found using beard's Boehm GC]
Priority: P3 → P2
Target Milestone: M11
Assignee: sfraser → jfrancis
accepting/m11
Target Milestone: M11 → M13
Severity: normal → critical
Priority: P2 → P1
Summary: [MLK] nsEditor::CreateNode() and nsEditor::RemoveAttribute() leak → [DOGFOOD][MLK] nsEditor::CreateNode() and nsEditor::RemoveAttribute() leak
Whiteboard: MAJOR LEAK
Target Milestone: M13 → M11
this is a major leak and we know the cause of the leak. So I am moving it back
to M11, setting priority to P1 and making it a dogfood candidate.
PDT team would like to know how big is major please.  Thanks!
Whiteboard: MAJOR LEAK → [PDT+]MAJOR LEAK
Just got info from rickg...putting on PDT+ :-)
Blocks: 12658
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
fixed
need help verifying this one Joe...
Status: RESOLVED → VERIFIED
i have verified that the editor no longer leaks transactions.
You need to log in before you can comment on or make changes to this bug.