1636421 - Merge Message panel with the Response panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The list of WS frames for (WS connection) and list of events (for SSE connections) should be displayed directly in the Response panel

• Better discoverability since the user doesn't have to search for yet another side panel.

Honza

Comment 1

[Farooq AR]

Attachment: Bug 1636421 - Rename MessagesPanel to MessagesView. r=Honza,bomsy

Comment 2

[Farooq AR]

Attachment: Bug 1636421 - Merge Message panel with the Response panel. r=Honza,bomsy

Depends on D80335

Comment 3

[Farooq AR]

Attachment: Bug 1636421 - Refactor response panel styles into separate file. r=Honza,bomsy

Depends on D80336

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ca604bb0675
Rename MessagesPanel to MessagesView. r=Honza,bomsy
https://hg.mozilla.org/integration/autoland/rev/9f708615a94d
Merge Message panel with the Response panel. r=Honza,bomsy
https://hg.mozilla.org/integration/autoland/rev/bd3d862e3d4a
Refactor response panel styles into separate file. r=Honza,bomsy

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The Messages panel is now merged with the Response panel. This means that WS messages (frames) as well as SSE events are now displayed in the Response panel. This is to reduce number of side panels and make the UI simpler.

This page should be updated
https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor/Inspecting_web_sockets
(not sure if there is any other page that needs update)

Honza

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6ca604bb0675
https://hg.mozilla.org/mozilla-central/rev/9f708615a94d
https://hg.mozilla.org/mozilla-central/rev/bd3d862e3d4a

Comment 7

[Janet Swisher]

Updated screenshots and descriptions in Inspecting web sockets. Also deleted section for Messages tab, and merged its content into Response tab section of the Request Details article.

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

There is one more screenshot that needs to be updated, see here:
https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor/Inspecting_web_sockets#Filtering_web_socket_frames

There is no Messages side panel anymore, all is displayed in the Response side panel

Here is a test case that can be used to generated screenshots:
http://janodvarko.cz/test/websockets/

Honza

Comment 9

[Chris Mills [:cmills]]

I've updated the outdated sections of https://wiki.developer.mozilla.org/en-US/docs/Tools/Network_Monitor/Inspecting_web_sockets, and added the new protocol support.

Comment 10

[Rory Haddon]

This seems less intuitive to me. We now have both requests and responses for the WebSocket on the "Responses" tab. This leads to the confusing user scenario where they have an empty "Requests" panel when the user might be searching for the requests (outgoing websocket messages).

One of the original arguments for this was "Better discoverability since the user doesn't have to search for yet another side panel." But this change effectively introduces two panels (one of which is blank!) in place of one panel 'Messages'.

It feels like this change was not well thought through.