Use SVG icons for the checkmarks in trees
Categories
(Thunderbird :: Theme, task)
Tracking
(Not tracked)
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
40.87 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
On some places we use PNG images for the checkmarks. We should use SVGs instead.
Assignee | ||
Comment 1•5 years ago
|
||
I converted the checkmarks for the subscribe-, select offline- and the virtual folder list dialogs.
I created for them shared CSS files which are used instead individual files per platform because they are for all platforms the same.
I removed virtualFolderListDialog.css completely and moved the code to the shared mailWindow1.css to not needing a special file for only two rules. I had to adapt virtualFolderListDialog.xhtml in mailnews. Because last time Magnus didn't want that we preprocess this files for SM and TB, I hard coded it to mailWindow1.css. SM needs to follow when they can use the trunk SM again.
I planned to convert the checkmark in filterDialog.css too but this will be no more needed when I use the themeableDialog.css. I created already the shared file and leave it now in this patch.
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Ian, we removed the virtualFolderListDialog.css and moved in virtualFolderListDialog.xhtml the link to messageWindow1.css instead. There are only two rules which you also can move to messageWindow1.css
(In reply to Richard Marti (:Paenglab) from comment #3)
Ian, we removed the virtualFolderListDialog.css and moved in virtualFolderListDialog.xhtml the link to messageWindow1.css instead. There are only two rules which you also can move to messageWindow1.css
Bug 1636553 logged to fix it, thanks.
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/bb8c9919df27
Use SVG icons for the checkmarks in trees. r=aleca DONTBUILD
Comment 6•5 years ago
|
||
This seems to have caused a test failure: https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedTaskRun=KDllea7RRgSQewLFomAeUQ-0
./mach test comm/mail/test/static/browser_parsable_css.js fails locally too
Looks like it's the "margin-inline: -6px;" in mail/themes/linux/mail/filterDialog.css
The test doesn't want to fully succeed for me locally now, not sure why. It doesn't fail for that one though, if I remove it.
Assignee | ||
Comment 7•5 years ago
|
||
That's strange. I checked the filterEditor in inspector and the rule is applied correctly. Does the test not like negative margins?
Comment 8•5 years ago
|
||
Only failed on one platform. Maybe a fluke...
Description
•