1636562 - Unsupported ::marker properties can be set with web animations

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Oriol Brufau [:Oriol]]

Attachment: testcase.html

The ::marker pseudo-element supports a limited set of properties: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo

In Firefox this is controlled by the layout.css.marker.restricted pref, make sure it's set to true (the default).

Then, run the attached testcase:

<ul>
  <li>list item</li>
</ul>
<script>
document.querySelector('li').animate([
  {opacity: 0},
  {opacity: 1},
], {
  pseudoElement: '::marker',
  duration: 1000,
});
</script>

Expected: opacity doesn't apply to ::marker so there should be no animation.
Actual: the opacity is animated.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Presumably we need to check property_restriction() here.

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=09a12f165cd33b7dc39c3f0ac59c476a70874990
Hopefully some tests give unexpected results here--otherwise this will need tests too

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1636562 - Respect property restrictions on pseudo elements when animating; r?boris

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a10d842d4e0fd450df00dc8e900bf57ddc4d2b1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbf04fb63a8a
Respect property restrictions on pseudo elements when animating; r=boris

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24694 for changes under testing/web-platform/tests

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fbf04fb63a8a

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot