Closed Bug 1636833 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23496 - [FlexNG] Use fragment order as source of truth within simplified layout

Categories

(Core :: Layout: Positioned, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23496 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23496
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[FlexNG] Use fragment order as source of truth within simplified layout

Step 3/4 in getting flex to use the simplified layout pass.

We need to use the fragment order as the source or truth as we use the
fragment order as the correct paint order.

The downside of this approach is that we now iterate twice over the
children, once for the fragments, and again for the nodes.

Adding placeholder fragments for the static-positions for the OOF
will fix this.

Bug: 845235
Change-Id: Idb149a25975885cee389c3bae1dd9021dbb5a467

Reviewed-on: https://chromium-review.googlesource.com/2187854
WPT-Export-Revision: 987272ae5e234406ecbed3000c100da4af42b78b

Component: web-platform-tests → Layout: Positioned
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7ed97376186
[wpt PR 23496] - [FlexNG] Use fragment order as source of truth within simplified layout, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d27c5ce5d6f
[wpt PR 23496] - [FlexNG] Use fragment order as source of truth within simplified layout, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.