Closed
Bug 1636921
Opened 4 years ago
Closed 4 years ago
Check fallible uses of FallibleTArray::AppendElement within loops in dom/vr/*
Categories
(Core :: WebVR, task)
Core
WebVR
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: sg, Assigned: daoshengmu)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Bug 1628715 identified several missing checks of failures for fallible calls of FallibleTArray::AppendElement. Part of these are within loops, and they could be improved by a call to SetCapacity outside the loop, which would also avoid unnecessary reallocations.
These locations have been marked with XXX(Bug 1632090). dom/vr/* contains one such case here: https://searchfox.org/mozilla-central/search?q=1632090&path=dom%2Fvr&case=false®exp=false
The remaining comments are planned to be removed by end of October 2020 if they have not been addressed by then, and this bug is going to be closed.
|
Assignee | |
Updated•4 years ago
|
Assignee: nobody → dmu
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by dmu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/220f158438e2 Calling SetCapacity for a FallibleTArray in XRInputSourceArray. r=sg,kip
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•