1636942 - Add an IC for JSOp::ToId

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

WarpBuilder currently always emits MToId for the JSOp::ToId for x[i] += y. We should consider adding an IC for JSOp::ToId, similar to what we did for JSOp::Pos (bug 1626297) and JSOp::ToNumeric (bug 1632761). Then we can easily add a fast path for int32/symbol/string and transpile it.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1636942 part 1 - Rename JSOp::ToId to JSOp::ToPropertyKey. r?evilpie!

Doesn't rename the MToId instruction because the next patch will make changes to
that anyway.

The comment in Interpreter.cpp was removed because this op is already (and better)
documented in vm/Opcodes.h

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1636942 part 2 - Add IC support for JSOp::ToPropertyKey. r?evilpie!

Just the fallback path, the next patch will add CacheIR support.

Depends on D78039

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1636942 part 3 - Add CacheIR generator for JSOp::ToPropertyKey. r?evilpie!

The only new op we needed was LoadSymbolResult.

Also adds transpiler support for GuardToSymbol.

Depends on D78040

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9eaf61ddb56f
part 1 - Rename JSOp::ToId to JSOp::ToPropertyKey. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/ea8ef46857c8
part 2 - Add IC support for JSOp::ToPropertyKey. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/a58c521bb767
part 3 - Add CacheIR generator for JSOp::ToPropertyKey. r=evilpie

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9eaf61ddb56f
https://hg.mozilla.org/mozilla-central/rev/ea8ef46857c8
https://hg.mozilla.org/mozilla-central/rev/a58c521bb767