1637067 - Blurred SVG - Background-image regression after 75.0b9

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[imagoiq]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Watch: https://codepen.io/MediaComem/pen/jOPveBv
The P letter is blurred on the right. This issue only happen since version 76.0 (last working version is 75.0b9)

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Robert Longson [:longsonr]]

Looks fine to me but I'm on a Mac. Perhaps you could find a regression range by using https://mozilla.github.io/mozregression/

Comment 3

[Firefox Bug Husbandry Bot]

Because this bug's Severity is normal and has not been changed, and this bug's priority is -- (none,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 4

[imagoiq]

Attachment: mozregression-gui_2020-05-12_08-30-50.png

Comment 5

[imagoiq]

Attachment: mozregression-gui_2020-05-12_08-30-59.png

Comment 6

[imagoiq]

Attachment: screenshot_blurred_edge.png

Comment 7

[imagoiq]

I've run the tool, it crash after "autoland build: c030dc56" (I've tried 3 times and filled a bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1637164). But in the end, it seems that the bisection is done. Seems related to: https://phabricator.services.mozilla.com/D69167

Comment 8

[Timothy Nikkel (:tnikkel)]

Attachment: reduced testcase

This is a reduced testcase.

Actually, this testcase shows a bug existed even before bug 1626259. This testcase is blurry even before bug 1626259 (whereas the original testcase looked pretty crisp before bug 1626259). It gets even more blurry after bug 1626259.

I should be able to make this testcase crisp, thus fixing the recent regression and fixing the pre-existing bug (it seemed to exist for quite a while before).

Comment 9

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1637067. Use the same kind of preserve3d in the StackingContextHelper constructor as in ChooseScale. r?jrmuizel

transform_style is set to frame->Extend3DContext, but ChooseScale uses frame->Combines3DTransformWithAncestors()

Comment 10

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1637067. Make the StackingContextHelper constructor handle transforms that cannot be drawn 2d the same as ChooseScale. r?jrmuizel

In StackingContextHelper::StackingContextHelper we want to handle the case of "no passed in transform" differently from "passed in transform but it cannot be drawn 2d". This is a little tricky because ChooseScale always has a transform passed in: in the non-wr case it is a scaling matrix by the parent scale. We could call ChooseScale if canDraw2D is false and get the same value for mScale but we also need to keep mInheritedTransform in sync.

This issue arose before: https://bugzilla.mozilla.org/show_bug.cgi?id=1449958#c3

And we want to be careful not to regress that bug, that bug was concerning content without a transform, so we should be good.

The testcase has a parent element with rotateY(-80deg) and a child element with rotateY(80deg), the combined transform is flat with no scaling even though each transform individually would have a very small x scale. There's no way to choose a good scale by looking at each transform individually, and since we only currently store transforms as 2d matrices we can't look at the full combined transform in order to choose a scale. Thus we must use a unit scale, like ChooseScale does.

Depends on D75288

Comment 11

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1637067. Add reftest, adjust fuzz expectations of existing test. r?jrmuizel

The existing test compares a 3d scene to a "hand drawn" version of the scene using 2d primitives and was never expected to match perfectly, but instead just provide something to compare against better than saying it's not a blank page.

The new test looks visually identical, the fuzz is around the edges of the text.

Depends on D75289

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14b1591d2a17
Use the same kind of preserve3d in the StackingContextHelper constructor as in ChooseScale. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/80fd72570c40
Make the StackingContextHelper constructor handle transforms that cannot be drawn 2d the same as ChooseScale. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/58f80ec5f2af
Add reftest, adjust fuzz expectations of existing test. r=jrmuizel

Comment 13

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1637067. Further adjust fuzz on preserve3d-scale.html for android hardware reftests.

Depends on D75636

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55af9d5c46de
Further adjust fuzz on preserve3d-scale.html for android hardware reftests.

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/14b1591d2a17
https://hg.mozilla.org/mozilla-central/rev/80fd72570c40
https://hg.mozilla.org/mozilla-central/rev/58f80ec5f2af

Comment 16

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/55af9d5c46de