Closed Bug 1637100 Opened 4 months ago Closed 4 months ago

[wpt-sync] Sync PR 23515 - Update Storage Access API Logic & E2E Tests

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23515 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23515
Details from upstream follow.

Brandon Maslen <brandm@microsoft.com> wrote:

Update Storage Access API Logic & E2E Tests

This change updates the logic used in the Blink document for
document.hasStorageAccess and document.requestStorageAccess. Gates have
been added to ensure the proper restrictions such as having a non-opaque
origin, sandbox token (if applicable), as well as ensuring that
hasStorageAccess reflects the actual state of storage access on the page.

Additionally defense in depth logic checks have been added in
StorageAccessGrantPermissionContext to shortcut if we get a request for
a scenario no grant would be needed.

Some additional cleanup is included with this change to remove the
temporary usage of CONTENT_SETTING_SESSION in
StorageAccessGrantPermissionContext and to ensure all content settings
updates will propagate to the network service. A follow up change will
ensure this does not result in duplicate updates when we perform our
initial update.

Browser tests have been added to validate end to end functionality.

Bug: 989663
Change-Id: I09fdc115a30a71e341961b385a2e2e05fd161536
Reviewed-on: https://chromium-review.googlesource.com/2194905
WPT-Export-Revision: 262f6502b6603c576054f9dce86b90b4a8c02943

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

PASS : 3
TIMEOUT: 1

Chrome

FAIL : 3
TIMEOUT: 1

Safari

PASS : 3
TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/storage-access-api/hasStorageAccess.sub.window.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e43d50d4c468
[wpt PR 23515] - Update Storage Access API Logic & E2E Tests, a=testonly
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.