Closed Bug 1637114 Opened 4 months ago Closed 4 months ago

[wpt-sync] Sync PR 23518 - Handle k-rate AudioParam inputs for AudioWorkletNode

Categories

(Core :: Web Audio, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23518 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23518
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Handle k-rate AudioParam inputs for AudioWorkletNode

Support k-rate input to AudioParams for an AudioWorkletNode.
Previously, inputs to a k-rate AudioParam were ignored, which is
incorrect. The input must be summed with any timeline value.

Manually ran the new test case with Chrome stable and the tests fail
as expected (output is constantly 0 which is wrong).

Bug: 1015760
Test: k-rate-audioworklet-connections.https.html
Change-Id: I5dbba311fb84b9a162e1b2ac4fc9ef902ff36eb6
Reviewed-on: https://chromium-review.googlesource.com/2194189
WPT-Export-Revision: c9bdb03040f9460dfc4a6965ff6947513ae95796

Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 72 tests

Status Summary

Firefox

OK : 1
PASS: 9[GitHub] 80[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 6

Chrome

OK : 1
PASS: 12
FAIL: 3

Safari

OK : 1
PASS: 5
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webaudio/the-audio-api/the-audioparam-interface/k-rate-audioworklet-connections.https.html
X k-rate output [256: 383]: Expected 5 for all values but found 127 unexpected values:
Index Actual
[1] 5.01953125
[2] 5.0390625
[3] 5.05859375
[4] 5.078125
...and 123 more errors.: FAIL
< [AudioWorklet k-rate AudioParam] 4 out of 5 assertions were failed.: FAIL
X k-rate output [0: 127]: Expected 0 for all values but found 127 unexpected values:
Index Actual
[1] 0.01953125
[2] 0.0390625
[3] 0.05859375
[4] 0.078125
...and 123 more errors.: FAIL
X k-rate output [384: 511]: Expected 7.5 for all values but found 127 unexpected values:
Index Actual
[1] 7.51953125
[2] 7.5390625
[3] 7.55859375
[4] 7.578125
...and 123 more errors.: FAIL

AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed.: FAIL (Chrome: FAIL)

X k-rate output [128: 255]: Expected 2.5 for all values but found 127 unexpected values:
Index Actual
[1] 2.51953125
[2] 2.5390625
[3] 2.55859375
[4] 2.578125
...and 123 more errors.: FAIL

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25602b875f88
[wpt PR 23518] - Handle k-rate AudioParam inputs for AudioWorkletNode, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ff79de95b893
[wpt PR 23518] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.