Closed Bug 1637285 Opened 1 year ago Closed 1 year ago

In high contrast mode stub installer progress bar shows 10% even with internet connection disabled

Categories

(Firefox :: Installer, defect, P2)

Product:
Firefox
Component:
Installer
Version:
77 Branch
Platform:
Desktop
Windows
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 78
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- unaffected
firefox77 --- wontfix
firefox78 --- verified

People

(Reporter: dcicas, Assigned: agashlin)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1637285 - Draw high contrast progress bar top border only. r?mhowell
47 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • Fx 77.0b4
    Fx 78.0a1

Affected platforms

  • Win 7
    Win 10
    Win aarch64

Steps to reproduce

  1. Disable internet connection.
  2. Enable high contrast mode.
  3. Start the stub installer.

Expected result

  • Progress bar shows 0%

Actual result

  • Progress bar shows 10%

Regression range
Will return with a regression range ASAP.

Additional notes

  • If high contrast mode is not enabled the progress bar shows 0%.
Blocks: 1632191

The visual artifact being described here is the border that was added to the progress bar to fix bug 1632203. Not immediately sure how to deal with it, but maybe Adam has ideas.

Keywords: regression
Regressed by: 1632203

Good catch! Yes, the bar can't be any narrower than it is high. I'll fix this by just setting border-top and border-bottom instead of all sides.

Assignee: nobody → agashlin
Severity: S2 → S3
Priority: -- → P2

This allows the bar to be any width.

Pushed by agashlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cae2bfa2adfe
Draw high contrast progress bar top border only. r=mhowell

https://hg.mozilla.org/mozilla-central/rev/cae2bfa2adfe

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78

Set release status flags based on info from the regressing bug 1632203

status-firefox76: --- → unaffected
status-firefox77: --- → affected

This is a 77 regression and the patch looks safe, Adam, do you want to request an uplift to beta?

Flags: needinfo?(agashlin)

Thanks Pascal, this is sufficiently minor and rare that I think it can just ride with 78.

Severity: S3 → S4
Flags: needinfo?(agashlin)
Flags: qe-verify+

Reproduced the issue with Firefox 77.0.
Verified as fixed with Firefox 78.0b7 stub installer on Windows 10 x64, Windows 7 x64 and Win aarch64.

Status: RESOLVED → VERIFIED
status-firefox78: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.