1637285 - In high contrast mode stub installer progress bar shows 10% even with internet connection disabled

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P2)

Description

[Daniel Cicas [:dcicas], Release QA]

Affected versions

• Fx 77.0b4
  Fx 78.0a1

Affected platforms

• Win 7
  Win 10
  Win aarch64

Steps to reproduce

1. Disable internet connection.
2. Enable high contrast mode.
3. Start the stub installer.

Expected result

• Progress bar shows 0%

Actual result

• Progress bar shows 10%

Regression range
Will return with a regression range ASAP.

Additional notes

• If high contrast mode is not enabled the progress bar shows 0%.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

The visual artifact being described here is the border that was added to the progress bar to fix bug 1632203. Not immediately sure how to deal with it, but maybe Adam has ideas.

Comment 2

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Good catch! Yes, the bar can't be any narrower than it is high. I'll fix this by just setting border-top and border-bottom instead of all sides.

Comment 3

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: Bug 1637285 - Draw high contrast progress bar top border only. r?mhowell

This allows the bar to be any width.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cae2bfa2adfe
Draw high contrast progress bar top border only. r=mhowell

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cae2bfa2adfe

Comment 6

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1632203

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

This is a 77 regression and the patch looks safe, Adam, do you want to request an uplift to beta?

Comment 8

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Thanks Pascal, this is sufficiently minor and rare that I think it can just ride with 78.

Comment 9

[Gabi Cheta [:Gabi] Desktop QA]

Reproduced the issue with Firefox 77.0.
Verified as fixed with Firefox 78.0b7 stub installer on Windows 10 x64, Windows 7 x64 and Win aarch64.