Closed Bug 1637367 Opened 4 years ago Closed 4 years ago

Android xpcshell harness sets GRE_HOME inappropriately

Categories

(Testing :: XPCShell Harness, defect, P1)

Version 3
defect

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

Details

(Whiteboard: [kaios])

Attachments

(1 file)

The Android xpcshell-test harness sets environment variable GRE_HOME to /data/data/org.mozilla.geckoview.test, when running against a geckoview build, or /data/data/<package-name> if it can determine a package name from an apk (as was supported in fennec). But org.mozilla.geckoview.test is not necessarily installed (never in CI, never for KaiOS) -- this is just pointing an environment variable to a non-existent directory. Surely we can do better!

It turns out this is why uriloader/exthandler/tests/unit/test_punycodeURIs.js has failed on Android for years.

Previously this would typically set GRE_HOME to /data/data/org.mozilla.geckoview.test,
even though org.mozilla.geckoview.test is not normally installed when running
xpcshell tests -- a non-existent directory in a privileged location!
The new location, remoteBinDir, is typically /data/local/xpcb, the location of the
xpcshell executable.

Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b703baa8a50
Improve GRE_HOME setting in remote xpcshell tests; r=bc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: