Closed Bug 1637423 Opened 6 years ago Closed 5 years ago

Retriggering a job fails initially when not logged in

Categories

(Tree Management :: Treeherder: Frontend, defect, P1)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sclements, Assigned: sclements)

Details

Attachments

(1 file)

I relaxed the login requirements in bug 1620160 since taskcluster credentials are separate and required to do any sort of PUT/POST request to taskcluster. Login to Treeherder is only really needed for writing to Treeherder's database (I think only classifications or adding notes by sheriffs).

However, I discovered a bug during our UX research interviews where taskcluster credentials will be checked before retriggering a job (regardless of whether the user is logged in or not). If they don't exist or have expired, they should be retrieved and then the action performed. Currently, they are retrieved but then an error is being thrown so users have to click again to actually retrigger and it's confusing.

Users are also expecting to be logged in when that happens, not just have taskcluster credentials retrieved (if necessary) and the action performed.

This pr only address the taskcluster credential/retriggering bug. I didn't address the confusion with it not performing the full login as some users were expecting (I'll leave that as part of the UX project improvements since I think there will need to be other changes to the login flow).

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: