163744 - error message displayed in terminal during startup from command-line

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Salim Virji]

User-Agent:       Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.0.0) Gecko/20020530
Build Identifier: Mozilla/5.0 (X11; U; HP-UX 9000/785; en-US; rv:1.0.1) Gecko/20020808

Starting Mozilla from the command-line, with the run-mozilla.sh script, produces
the message "md5sum not found." This seems to come from a check performed at
startup for an md5 checksumming program, which is not present on all platforms
or in all environments.
This does not affect mozilla startup; it simply produces an unnecessary piece of
debugging information.

Reproducible: Always

Steps to Reproduce:
1. start Mozilla using the run-mozilla.sh script
% ./run-mozilla.sh
2. the line "md5sum not found." will appear on screen
3. Mozilla continues to start normally

Actual Results:  
The ine "md5sum not found." appeared on screen, and Mozilla started normally.

Expected Results:  
Not displayed anything, unless, perhaps the -g (or -debug) switch was enabled.

This can be worked around by using an icon; however, users accustomed to
command-line startup, but without an md5 program in their path, will continue to
see the line of error output.

Comment 1

[Salim Virji]

Adding ccs for people who have worked on this file previously.

Comment 2

[hacker formerly known as [e-mail]]

Attachment: redirect STDERR to /dev/null

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 96131 [details] [diff] [review]
redirect STDERR to /dev/null

r=bryner

Comment 4

[hacker formerly known as [e-mail]]

Patch has been checked in.

Comment 5

[Salim Virji]

the error output (md5sum not found) still appears during startup. This might be
due to bad behaviour on the part of the type command. 

Comment 6

[Philip K. Warren]

Attachment: Redirect errors from 'type' command

The correct fix on AIX (and likely HP-UX from the comments above) is to
redirect the error output from the 'type' command, not the 'md5sum' command.
This prevents the warning from showing up on AIX which does not ship the GNU
md5sum program by default.

Comment 7

[hacker formerly known as [e-mail]]

*** Bug 184762 has been marked as a duplicate of this bug. ***

Comment 8

[Philip K. Warren]

Requesting driver's approval for checkin to Mozilla 1.3. This is a one-line,
zero risk patch which fixes a warning message from being printed on Unix
machines which do not ship with the GNU md5sum program.

Comment 9

[Asa Dotzler [:asa]]

pkw, it's not necessary to use the "blocking1.3?" request to get a patch landed.
Only set that flag if you feel that drivers should block the release for this
particular problem. If you want to request approval for a patch to land, the
patch approval flag is all that's required. 

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 110417 [details] [diff] [review]
Redirect errors from 'type' command

a=asa (on behalf of drivers) for checkin to 1.3 final.

Comment 11

[Philip K. Warren]

Fixed:

/cvsroot/mozilla/build/unix/run-mozilla.sh,v  <--  run-mozilla.sh
new revision: 1.45; previous revision: 1.44
done

Comment 12

[Philip K. Warren]

Verified in yesterday's build.