Closed Bug 1637442 Opened 1 year ago Closed 11 months ago

[wpt-sync] Sync PR 23551 - CookieStore: Remove secure from modification API

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23551 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23551
Details from upstream follow.

Ayu Ishii <ayui@chromium.org> wrote:

CookieStore: Remove secure from modification API

This change removes secure option from modification API per
discussion [1].

[1] https://github.com/WICG/cookie-store/issues/121

Bug: 1069670
Change-Id: I1f32016b05df4b750ccbf237e1c5de10a6ed85de

Reviewed-on: https://chromium-review.googlesource.com/2196805
WPT-Export-Revision: 489876c1a952b4688f5b8701297b4d245f8511af

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 73 tests

Status Summary

Firefox

OK : 2
PASS: 71
FAIL: 30

Chrome

OK : 2
PASS: 30

Safari

OK : 2
FAIL: 30

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cookie-store/cookieListItem_attributes.tentative.https.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with positional name and value and sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with positional name and value and sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with name and value in options and expires set to a future Date: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with name and value in options and expires set to a future timestamp: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with positional name and value and sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieListItem_attributes.tentative.https.any.serviceworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
CookieListItem - cookieStore.set with sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set defaults with name and value in options: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set defaults with positional name and value: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with positional name and value and sameSite set to none: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with expires set to a Date 10 years in the future: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with positional name and value and sameSite set to lax: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with name and value in options and expires set to a future Date: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with expires set to a timestamp 10 years in the future: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set adds / to path if it does not end with /: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with name and value in options and expires set to a future timestamp: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with positional name and value and sameSite set to strict: FAIL (Chrome: PASS, Safari: FAIL)
CookieListItem - cookieStore.set with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/cookie-store/cookieListItem_attributes.tentative.https.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/cookie-store/cookieListItem_attributes.tentative.https.any.serviceworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9e87df182b0
[wpt PR 23551] - CookieStore: Remove secure from modification API, a=testonly
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.