1637535 - Compatibility panel - Settings close [x] button has double focus rings applied on tab-select

Status: VERIFIED FIXED

(DevTools :: Inspector: Compatibility, defect, P3)

Description

[Cristian Fogel, QA [:cfogel]]

Attachment: Screenshot 0002-05-13 at 11.31.18.png

Affected versions

• 78.0a1 (2020-05-12)

Affected platforms

• Windows 10, macOS 10.15.3, Ubuntu 18;

Steps to reproduce

• devtools.inspector.compatibility.enabled preff on true;

1. Launch Firefox, access any webpage;
2. Enable devtools Inspector - Compatibility tab;
3. Click on the bottom Settings button;
4. Click / tab-select the [x] button for the Settings view;

Expected result

• just one focus-ring just on the [x] button, surrounding just the button;

Actual result

• double focus rings displayed;

Regression range

• not a regression;

Additional notes

• attached screenshot with the issue;

Comment 1

[:Gijs (he/him)]

Emilio, is this fallout from your focus changes?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I think this should be fixed as of bug 1637771.

Comment 3

[:Gijs (he/him)]

Cristian, can you confirm if this is fixed on builds after bug 1637771?

Comment 4

[Cristian Fogel, QA [:cfogel]]

Thank you for the poke.
Indeed, this issue is no longer encountered.