1637665 - ./mach run doesn't work on Mac with --enable-application=js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Jason Orendorff [:jorendorff]]

$ ./mach run
Error running mach:

    ['run']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

KeyError: 'MOZ_MACBUNDLE_NAME'

  File "/Users/jorendorff/work/mozilla-central/python/mozbuild/mozbuild/mach_commands.py", line 867, in run
    return self._run_jsshell(**kwargs)
  File "/Users/jorendorff/work/mozilla-central/python/mozbuild/mozbuild/mach_commands.py", line 952, in _run_jsshell
    binpath = self.get_binary_path('app')
  File "/Users/jorendorff/work/mozilla-central/python/mozbuild/mozbuild/base.py", line 561, in get_binary_path
    stem = os.path.join(stem, substs['MOZ_MACBUNDLE_NAME'], 'Contents',

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1637665 - make `mach run` work with the JS shell on OS X; r=#build

We need to skip the xulrunner/browser code (do we even support xulrunner
anymore?) for --enable-application=js builds. MOZ_WIDGET_TOOLKIT is
used elsewhere to check for "browserness".

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db1aba95a73b
make `mach run` work with the JS shell on OS X; r=firefox-build-system-reviewers,rstewart

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/db1aba95a73b