1637680 - Some data is not persisted if the app is killed at the wrong time

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect, P1)

Description

[[PTO until Jun 3rd] Agi Sferro | :agi | ni? for questions | ⏰ PST | he/him]

Follow up from Bug 1634493.

Talked about this with :snorp, :mixedpuppy, :aswan.

We have a few cases of Gecko code using DeferredTask to persist data to disk at a later time which doesn't work on Android since there are no shutdown tasks. We could run some of them when receiving application-background.

Comment 1

[[PTO until Jun 3rd] Agi Sferro | :agi | ni? for questions | ⏰ PST | he/him]

Attachment: Bug 1637680 - Make softDisable setter async.

Some tests rely on the order of execution of the blocklist code which cannot be
guaranteed if we don't wait for the enabled state to settle.

In particular, when calling _onUpdate in
AddonTestUtils.loadBlocklistRawData in 0 we implicitely assume that all the
actions deriving from updating the blocklist settle before the promise is
completed, this is not true for the enabled state.

Currently the test succedes because ExtensionPermissions.get is not actually
async in most cases, this is about to change in the next patch.

Comment 2

[[PTO until Jun 3rd] Agi Sferro | :agi | ni? for questions | ⏰ PST | he/him]

Attachment: Bug 1637680 - Use rkv in ExtensionPermissions.

Comment 3

[[PTO until Jun 3rd] Agi Sferro | :agi | ni? for questions | ⏰ PST | he/him]

Attachment: Bug 1637680 - Register incognito permission early in tests.

This is needed so that extensions can access incognito tabs during early
background script startup in tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/116a28847684
Make softDisable setter async. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/9528ab23db09
Use rkv in ExtensionPermissions. r=mixedpuppy,robwu
https://hg.mozilla.org/integration/autoland/rev/2e2818afa107
Register incognito permission early in tests. r=mixedpuppy

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/116a28847684
https://hg.mozilla.org/mozilla-central/rev/9528ab23db09
https://hg.mozilla.org/mozilla-central/rev/2e2818afa107