1637783 - Relax crash assertion in DocumentChannel::SetLoadFlags

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P3)

Comment 1

[u480271]

Attachment: Bug 1637783 - Relax SetLoadFlags hard assert to soft assert.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/941289b031c2
Relax SetLoadFlags hard assert to soft assert. r=mattwoodrow

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/941289b031c2

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9148190 [details]
Bug 1637783 - Relax SetLoadFlags hard assert to soft assert.

Beta/Release Uplift Approval Request

• User impact if declined: Crashing assert in rare cases
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just relaxes an assertion
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9148190 [details]
Bug 1637783 - Relax SetLoadFlags hard assert to soft assert.

Approved for our last beta, thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ceba705bb2a7