Closed Bug 1637825 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23586 - [FlexNG] Fix hittesting for pseudo-element flex-items.

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23586 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23586
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[FlexNG] Fix hittesting for pseudo-element flex-items.

pseudo-elements are a little different when it comes to hit-testing.
If they get hit, they don't nessecerily add themselves as the resulting
node hit-test. Instead the parent which requested the hit-test will
try and add themselves if no node is present.

We had this logic previously, but only for non-atomically painted
block-level children.

This patch adds this logic for atomically painted block-level children.

Bug: 1081789
Change-Id: I2d013dea0f865c80cedc3ed70ca80f0aea83b308

Reviewed-on: https://chromium-review.googlesource.com/2200280
WPT-Export-Revision: 3600bc4b1af377d5524947735b9cf7056bb3847e

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 72 tests

Status Summary

Firefox

OK : 1
PASS: 1[GitHub] 72[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6222e99112e8
[wpt PR 23586] - [FlexNG] Fix hittesting for pseudo-element flex-items., a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.