1637988 - Update ProfilerGetSymbols and consumers to look more like a local symbol server

Status: RESOLVED DUPLICATE of bug 1721109

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

Description

[Markus Stange [:mstange]]

This is preparatory work for bug 1563316.

In this bug I want to lay the groundwork for having a "local symbol server" in a WebAssembly worker, and use that new infrastructure for the existing getSymbolTable method. Some of the abstractions don't make a lot of sense for getSymbolTable, but they will make sense for the future handleAPIRequest method.

Generally, more responsibility for finding binary and debug files will move into the worker. Finding and reading files will be coordinated by the Rust / WebAssembly code, with Gecko JS code providing the necessary callback functions.

Comment 1

[Markus Stange [:mstange]]

The corresponding pull request on the profiler-get-symbols side is https://github.com/mstange/profiler-get-symbols/pull/8.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1637988 - Update ProfilerGetSymbols and consumers to look more like a local symbol server.

This updates ProfilerGetSymbols and callers for PR #8:
https://github.com/mstange/profiler-get-symbols/pull/8

Now everything has more levels of indirection.
The payoff from this is not immediately obvious in this commit.
It'll become clearer once we support the JSON symbolication API.

Comment 3

[Markus Stange [:mstange]]

Looking at this again, I think it makes more sense to handle this together with bug 1563316, rather than on its own.

Comment 4

[Phabricator Automation]

Comment on attachment 9148371 [details]
Bug 1637988 - Update ProfilerGetSymbols and consumers to look more like a local symbol server.

Revision D75316 was moved to bug 1563316. Setting attachment 9148371 [details] to obsolete.

Comment 5

[Markus Stange [:mstange]]

This was done in bug 1721109.