1638020 - Avoid checking display port twice while computing RDL rebuild region

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement)

Comment 1

[Miko Mynttinen]

Attachment: Bug 1638020 - Avoid checking display port twice while computing RDL rebuild region r=tnikkel

Comment 2

[Miko Mynttinen]

Attachment: Bug 1638020 - Avoid checking display port twice while computing RDL rebuild region r=tnikkel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c66945aba519
Avoid checking display port twice while computing RDL rebuild region r=tnikkel

Comment 4

[Razvan Maries]

Backed out for perma failures on RetainedDisplayListBuilder.cpp.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=A4LHaWYpSDSBNXGJVowb2g-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=c66945aba5193e014a0395f270b0368dc5d06b96

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302458510&repo=autoland&lineNumber=1516

Backout: https://hg.mozilla.org/integration/autoland/rev/54b7351d87ebdf372ad0e721cb83fe7f807927f5

Comment 5

[Botond Ballo [:botond]]

Based on this comment, the issue causing the test failures could be that we are now entering this if branch for both the scroll frame and the scrolled frame, whereas previously we would only enter it for the scroll frame.

Comment 6

[Miko Mynttinen]

(In reply to Botond Ballo [:botond] from comment #5)

Based on this comment, the issue causing the test failures could be that we are now entering this if branch for both the scroll frame and the scrolled frame, whereas previously we would only enter it for the scroll frame.

Yup. This was an oversight on my part.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3457d9d76ba
Avoid checking display port twice while computing RDL rebuild region r=tnikkel

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e3457d9d76ba