1638068 - Stop setting toolkit.cosmeticAnimations.enabled in extension tests

Status: RESOLVED FIXED

(WebExtensions :: General, task)

Description

[Dão Gottwald [::dao]]

The toolkit.cosmeticAnimations.enabled pref is going away. browser_ext_browserAction_popup_resize.js, browser_ext_browserAction_popup_resize_bottom.js and browser_ext_popup_select.js appear to be setting this for no particular reason.

Comment 1

[Kris Maglione [:kmag]]

They set it because the cosmetic animations made the timings of panel resizes unpredictable, and tended to lead to intermittent failures on some platforms. If that no longer happens, the pref changes can be removed.

Comment 2

[Dão Gottwald [::dao]]

(In reply to Kris Maglione [:kmag] from comment #1)

They set it because the cosmetic animations made the timings of panel resizes unpredictable, and tended to lead to intermittent failures on some platforms. If that no longer happens, the pref changes can be removed.

What animations specifically?

Comment 3

[Kris Maglione [:kmag]]

(In reply to Dão Gottwald [::dao] from comment #2)

(In reply to Kris Maglione [:kmag] from comment #1)

They set it because the cosmetic animations made the timings of panel resizes unpredictable, and tended to lead to intermittent failures on some platforms. If that no longer happens, the pref changes can be removed.

What animations specifically?

I don't remember the exact details, but it had to do with resizes and transitions of panels that held browser action popup content. It may have only applied to the ones in the hamburger menu, but I'm not sure.

Comment 4

[Dão Gottwald [::dao]]

Only browser/components/newtab/lib/CFRPageActions.jsm and toolkit/components/alerts/resources/content/alert.js read the pref at this point.

Comment 5

[Dão Gottwald [::dao]]

Attachment: Bug 1638068 - Stop setting toolkit.cosmeticAnimations.enabled in extension tests. r=kmag

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc8dc1800a98
Stop setting toolkit.cosmeticAnimations.enabled in extension tests. r=Gijs

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fc8dc1800a98