Closed Bug 1638068 Opened 11 months ago Closed 11 months ago

Stop setting toolkit.cosmeticAnimations.enabled in extension tests

Categories

(WebExtensions :: General, task)

task
Points:
1

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Iteration:
78.2 - May 18 - May 31
Tracking Status
firefox78 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The toolkit.cosmeticAnimations.enabled pref is going away. browser_ext_browserAction_popup_resize.js, browser_ext_browserAction_popup_resize_bottom.js and browser_ext_popup_select.js appear to be setting this for no particular reason.

They set it because the cosmetic animations made the timings of panel resizes unpredictable, and tended to lead to intermittent failures on some platforms. If that no longer happens, the pref changes can be removed.

(In reply to Kris Maglione [:kmag] from comment #1)

They set it because the cosmetic animations made the timings of panel resizes unpredictable, and tended to lead to intermittent failures on some platforms. If that no longer happens, the pref changes can be removed.

What animations specifically?

Flags: needinfo?(kmaglione+bmo)

(In reply to Dão Gottwald [::dao] from comment #2)

(In reply to Kris Maglione [:kmag] from comment #1)

They set it because the cosmetic animations made the timings of panel resizes unpredictable, and tended to lead to intermittent failures on some platforms. If that no longer happens, the pref changes can be removed.

What animations specifically?

I don't remember the exact details, but it had to do with resizes and transitions of panels that held browser action popup content. It may have only applied to the ones in the hamburger menu, but I'm not sure.

Flags: needinfo?(kmaglione+bmo)

Only browser/components/newtab/lib/CFRPageActions.jsm and toolkit/components/alerts/resources/content/alert.js read the pref at this point.

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc8dc1800a98
Stop setting toolkit.cosmeticAnimations.enabled in extension tests. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.