Closed Bug 1638123 Opened 2 years ago Closed 2 years ago

Call WebGLContext::ClearVRFrame when ending WebXR session.

Categories

(Core :: WebVR, enhancement)

Product:
Core
Component:
WebVR
Platform:
All
Android
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: mortimergoro, Assigned: mortimergoro)

Details

Attachments

(1 file)

Bug 1638123 - Call WebGLContext::ClearVRFrame when ending WebXR session.
47 bytes, text/x-phabricator-request
Details | Review

In WebVR we call WebGLContext::ClearVRFrame when the presentation ends. We didn't have the equivalent call in WebXR. It helps to reduce memory usage earlier when exiting WebXR and reduces potential deadlocks if the ExternalVR client didn't call SurfaceTexture->Release() correctly.

Assignee: nobody → imanol

In WebVR we call WebGLContext::ClearVRFrame when the presentation ends. We didn't have the equivalent call in WebXR. It helps to reduce memory usage earlier when exiting WebXR and reduces potential deadlocks if the ExternalVR client didn't call SurfaceTexture->ReleaseTexImage() correctly.

Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e282e2fd1200
Call WebGLContext::ClearVRFrame when ending WebXR session. r=jgilbert,kip,daoshengmu

https://hg.mozilla.org/mozilla-central/rev/e282e2fd1200

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.