Closed Bug 1638142 Opened 4 years ago Closed 4 years ago

OpenPGP Import notification bar is still visible when Message Pane is empty

Categories

(MailNews Core :: Security: OpenPGP, defect, P1)

Tracking

(thunderbird77 fixed)

RESOLVED FIXED
Thunderbird 78.0
Tracking Status
thunderbird77 --- fixed

People

(Reporter: aleca, Assigned: KaiE)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

After selecting a message that triggers the visibility of the "Import" OpenPGP key notification bar, if you click on a folder with no messages to preview, the Message Pane is empty but still shows the OpenPGP notification bar.

Thanks for the report. It's probably necessary to hide those panes in a message unload notification.

Assignee: nobody → kaie

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/01c458714912
Hide OpenPGP notification bars when moving away from a message. r=PatrickBrunschwig

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment on attachment 9149323 [details]
Bug 1638142 - Hide OpenPGP notification bars when moving away from a message. r=PatrickBrunschwig

Request to uplift OpenPGP improvements to Beta 77

Bug 8 of 9

https://hg.mozilla.org/comm-central/rev/01c458714912

[Approval Request Comment]
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): only affects openpgp

Attachment #9149323 - Flags: approval-comm-beta?

Needs a follow-up fix that adds null checks, automated tests on Win/macOS revealed a init/shutdown race where document.getElementById fails in some scenarios.

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/1ba0182395a4
Follow up fix to protect against document.getElementById returning null. rs=bustage

Comment on attachment 9149323 [details]
Bug 1638142 - Hide OpenPGP notification bars when moving away from a message. r=PatrickBrunschwig

Approved for beta

Attachment #9149323 - Flags: approval-comm-beta? → approval-comm-beta+
Target Milestone: --- → Thunderbird 78.0
You need to log in before you can comment on or make changes to this bug.