OpenPGP Import notification bar is still visible when Message Pane is empty
Categories
(MailNews Core :: Security: OpenPGP, defect, P1)
Tracking
(thunderbird77 fixed)
Tracking | Status | |
---|---|---|
thunderbird77 | --- | fixed |
People
(Reporter: aleca, Assigned: KaiE)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
121.74 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
|
Details | Review |
After selecting a message that triggers the visibility of the "Import" OpenPGP key notification bar, if you click on a folder with no messages to preview, the Message Pane is empty but still shows the OpenPGP notification bar.
Assignee | ||
Comment 1•4 years ago
|
||
Thanks for the report. It's probably necessary to hide those panes in a message unload notification.
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/01c458714912
Hide OpenPGP notification bars when moving away from a message. r=PatrickBrunschwig
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9149323 [details]
Bug 1638142 - Hide OpenPGP notification bars when moving away from a message. r=PatrickBrunschwig
Request to uplift OpenPGP improvements to Beta 77
Bug 8 of 9
https://hg.mozilla.org/comm-central/rev/01c458714912
[Approval Request Comment]
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): only affects openpgp
Assignee | ||
Comment 5•4 years ago
|
||
Needs a follow-up fix that adds null checks, automated tests on Win/macOS revealed a init/shutdown race where document.getElementById fails in some scenarios.
Pushed by kaie@kuix.de: https://hg.mozilla.org/comm-central/rev/1ba0182395a4 Follow up fix to protect against document.getElementById returning null. rs=bustage
Comment 7•4 years ago
|
||
Comment on attachment 9149323 [details]
Bug 1638142 - Hide OpenPGP notification bars when moving away from a message. r=PatrickBrunschwig
Approved for beta
Assignee | ||
Comment 8•4 years ago
|
||
Updated•4 years ago
|
Description
•