Fix JS users of rootTreeItem
Categories
(Core :: DOM: Navigation, task, P3)
Tracking
()
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files, 1 obsolete file)
Assignee | ||
Comment 1•11 months ago
|
||
Assignee | ||
Comment 2•11 months ago
|
||
Assignee | ||
Comment 3•11 months ago
|
||
Updated•11 months ago
|
Updated•11 months ago
|
Assignee | ||
Comment 4•11 months ago
|
||
Updated•11 months ago
|
Updated•11 months ago
|
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5a656842e241 Part 0 - Add Window.browsingContext getter. r=peterv https://hg.mozilla.org/integration/autoland/rev/07ec713926c6 Part 1 - Add topChromeWindow getter to CanonicalBrowsingContext. r=nika https://hg.mozilla.org/integration/autoland/rev/f7aedc92d396 Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Comment 7•11 months ago
|
||
Backed out for perma failures.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304585972&repo=autoland&lineNumber=3721
Backout: https://hg.mozilla.org/integration/autoland/rev/73d97f8335881e7de9e7bb6ad999cac8ca2c5a7c
Comment 8•11 months ago
|
||
That's probably a bad interaction between ChromeOnly and CrossOriginReadable.
Comment 9•11 months ago
|
||
We might need to filter out ChromeOnly properties in the codegen in CGCrossOriginProperties.
Comment 10•11 months ago
|
||
I put up a patch in bug 1643457 that should fix the failure from comment 7.
Comment 11•10 months ago
|
||
Kmag: I did land the fix for bug 1643457 two weeks ago, so you could try relanding this?
Assignee | ||
Comment 12•10 months ago
|
||
(In reply to Peter Van der Beken [:peterv] from comment #11)
Kmag: I did land the fix for bug 1643457 two weeks ago, so you could try relanding this?
I did, but apparently the landing failed and I didn't notice. I'll rebase and try again.
Comment 13•10 months ago
|
||
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/913b8e7489de Part 0 - Add Window.browsingContext getter. r=peterv https://hg.mozilla.org/integration/autoland/rev/911a985c6b73 Part 1 - Add topChromeWindow getter to CanonicalBrowsingContext. r=nika https://hg.mozilla.org/integration/autoland/rev/ba4656e730c4 Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp
Comment 14•10 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/913b8e7489de
https://hg.mozilla.org/mozilla-central/rev/911a985c6b73
https://hg.mozilla.org/mozilla-central/rev/ba4656e730c4
Updated•10 months ago
|
Description
•