1638153 - Fix JS users of rootTreeItem

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1638153: Part 2 - Fix uses of .rootTreeItem to get top browser window. r=nika

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1638153: Part 0 - Add Window.browsingContext getter. r=peterv

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1638153: Part 1 - Add topChromeWindow getter to CanonicalBrowsingContext. r=nika

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1638153: Part 0 - Add Window.browsingContext getter. r=peterv

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a656842e241
Part 0 - Add Window.browsingContext getter. r=peterv
https://hg.mozilla.org/integration/autoland/rev/07ec713926c6
Part 1 - Add topChromeWindow getter to CanonicalBrowsingContext. r=nika
https://hg.mozilla.org/integration/autoland/rev/f7aedc92d396
Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp

Comment 7

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=Q3NBUOeIQUevpTXr8XqUSQ-0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-linux1804-64%2Fdebug-web-platform-tests-e10s-16%2Cw%28wpt16%29&revision=f7aedc92d396d9170c88af862ec0871bf4a0f6cd

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304585972&repo=autoland&lineNumber=3721

Backout: https://hg.mozilla.org/integration/autoland/rev/73d97f8335881e7de9e7bb6ad999cac8ca2c5a7c

Comment 8

[Peter Van der Beken [:peterv]]

That's probably a bad interaction between ChromeOnly and CrossOriginReadable.

Comment 9

[Peter Van der Beken [:peterv]]

We might need to filter out ChromeOnly properties in the codegen in CGCrossOriginProperties.

Comment 10

[Peter Van der Beken [:peterv]]

I put up a patch in bug 1643457 that should fix the failure from comment 7.

Comment 11

[Peter Van der Beken [:peterv]]

Kmag: I did land the fix for bug 1643457 two weeks ago, so you could try relanding this?

Comment 12

[Kris Maglione [:kmag]]

(In reply to Peter Van der Beken [:peterv] from comment #11)

Kmag: I did land the fix for bug 1643457 two weeks ago, so you could try relanding this?

I did, but apparently the landing failed and I didn't notice. I'll rebase and try again.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/913b8e7489de
Part 0 - Add Window.browsingContext getter. r=peterv
https://hg.mozilla.org/integration/autoland/rev/911a985c6b73
Part 1 - Add topChromeWindow getter to CanonicalBrowsingContext. r=nika
https://hg.mozilla.org/integration/autoland/rev/ba4656e730c4
Part 2 - Fix uses of .rootTreeItem to get top browser window. r=geckoview-reviewers,nika,snorp

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/913b8e7489de
https://hg.mozilla.org/mozilla-central/rev/911a985c6b73
https://hg.mozilla.org/mozilla-central/rev/ba4656e730c4