1638172 - avoid name hiding for handling multipart channel in HttpChannelChild

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Description

[Junior [inactive]]

https://phabricator.services.mozilla.com/D73136#inline-437803

Comment 1

[Junior [inactive]]

Attachment: Bug 1638172 - avoid name hiding for handling multipart channel in HttpChannelChild, r=mayhemer

Depends on D73136

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/440612f47d83
avoid name hiding for handling multipart channel in HttpChannelChild, r=mayhemer

Comment 3

[Junior [inactive]]

I don't know why I can pass the build on my local once. Sorry for the inconvenience of the backout .

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 440612f47d83 (bug 1638172) for HttpChannelParent.cpp related bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=440612f47d83dffb36cbf342c8d349e86f13e6b6&searchStr=build&tochange=320ad722da7f659f55a146ee4e2b5c0b0699557f&selectedTaskRun=QrMxI8pzTumrVRnW3CQXAA-0

Backout link: https://hg.mozilla.org/integration/autoland/rev/320ad722da7f659f55a146ee4e2b5c0b0699557f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303292913&repo=autoland&lineNumber=21293

[task 2020-05-21T23:14:17.908Z] 23:14:17     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/netwerk/protocol/http'
[task 2020-05-21T23:14:17.908Z] 23:14:17     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_protocol_http1.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/workspace/obj-build/netwerk/protocol/http -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/extensions/auth -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/cookie -I/builds/worker/checkouts/gecko/netwerk/dns -I/builds/worker/checkouts/gecko/netwerk/ipc -I/builds/worker/checkouts/gecko/netwerk/socket/neqo_glue -I/builds/worker/checkouts/gecko/netwerk/url-classifier -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_protocol_http1.o.pp   Unified_cpp_protocol_http1.cpp
[task 2020-05-21T23:14:17.908Z] 23:14:17     INFO -  In file included from Unified_cpp_protocol_http1.cpp:110:
[task 2020-05-21T23:14:17.909Z] 23:14:17    ERROR -  /builds/worker/checkouts/gecko/netwerk/protocol/http/HttpChannelParent.cpp:1502:25: error: no member named 'GetContentType' in 'nsIMultiPartChannel'
[task 2020-05-21T23:14:17.909Z] 23:14:17     INFO -        multiPartChannel->GetContentType(contentType);
[task 2020-05-21T23:14:17.909Z] 23:14:17     INFO -        ~~~~~~~~~~~~~~~~  ^
[task 2020-05-21T23:14:17.909Z] 23:14:17     INFO -  1 error generated.
[task 2020-05-21T23:14:17.909Z] 23:14:17     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:746: recipe for target 'Unified_cpp_protocol_http1.o' failed
[task 2020-05-21T23:14:17.909Z] 23:14:17    ERROR -  make[4]: *** [Unified_cpp_protocol_http1.o] Error 1
[task 2020-05-21T23:14:17.909Z] 23:14:17     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/protocol/http'
[task 2020-05-21T23:14:17.909Z] 23:14:17     INFO -  /builds/worker/checkouts/gecko/config/recurse.mk:74: recipe for target 'netwerk/protocol/http/target-objects' failed
[task 2020-05-21T23:14:17.909Z] 23:14:17    ERROR -  make[3]: *** [netwerk/protocol/http/target-objects] Error 2
[task 2020-05-21T23:14:17.910Z] 23:14:17     INFO -  make[3]: *** Waiting for unfinished jobs....

Comment 5

[Junior [inactive]]

Thanks for backing this out.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cf4772a76c1
avoid name hiding for handling multipart channel in HttpChannelChild, r=mayhemer

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5cf4772a76c1