1638237 - (meta) mochitest errors and warnings from FULL DEBUG version of TB.

Status: NEW

(Thunderbird :: General, defect)

Description

[ISHIKAWA, Chiaki]

Attachment: error/warning summar of mochitest log with FULL DEBUG version of TB.

Most directly related bug is:
bug 303545 [Meta] Javascript strict warnings and errors (Thunderbird)
Maybe also
bug 998697 thunderbird termination errors/warnings [meta]

Hi, mochitest is here to stay for TB. |make mozmill| is gone since December 2019.

I had tough time to figure out converting my script to summarize the errors/warnings in the log spewed by mochitest and xpcshell-test (I try to handle them both with a single script, but now that mochitest has changed the output format pretty much, I need to tinker with the script for a while.)

Now that I have been able to create a somewhat sanitized output (still not so greatly simplified or tidied up) , I am uploading the excerpt from it.

The reason I wanted to upload this is that I think we really ought to handle a few legitimate errors seriously. See the following.

  113:  JavaScript error: chrome://messenger/content/customizableui/panelUI.js, line 1346: TypeError: can't access property "firstChild", container is undefined
   20:  JavaScript warning: resource://gre/modules/Troubleshoot.jsm, line 626: WebGL context was lost.
   17:  JavaScript error: chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js, line 483: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMessageService.messageURIToMsgHdr]
    7:  JavaScript error: resource:///modules/activity/alertHook.jsm, line 49: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgMailNewsUrl.server]
    4:  JavaScript error: resource://testing-common/BrowserTestUtilsChild.jsm, line 267: TypeError: can't access property "href", aEvent.target.location is undefined
    3:  JavaScript error: chrome://messenger/content/messengercompose/MsgComposeCommands.js, line 5257: TypeError: can't access property "key", gCurrentIdentity is null
    2:  JavaScript error: chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js, line 483: NS_ERROR_FACTORY_NOT_REGISTERED: Component returned failure code: 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED) [nsIMessenger.messageServiceFromURI]
    2:  JavaScript error: chrome://messenger/content/folderDisplay.js, line 1930: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgDBView.doCommand]
    1:  JavaScript error: resource://services-settings/IDBHelpers.jsm, line 24: Error: IndexedDB: security-state/cert-revocations list() IndexedDB:  execute() The application is shutting down
    1:  JavaScript error: resource://gre/modules/LoginHelper.jsm, line 1192: NS_ERROR_FAILURE: This login already exists.
    1:  JavaScript error: resource://gre/modules/IMIncomingServer.jsm, line 165: TypeError: can't access property "setBool", this.imAccount is null
    1:  JavaScript error: resource:///modules/imXPCOMUtils.jsm, line 272: TypeError: can't access property "values", this._items is undefined
    1:  JavaScript error: resource:///modules/OTRUI.jsm, line 229: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "can't access property "values", this._items is undefined" {file: "resource:///modules/imXPCOMUtils.jsm" line: 272}]'[JavaScript Error: "can't access property "values", this._items is undefined" {file: "resource:///modules/imXPCOMUtils.jsm" line: 272}]' when calling method: [nsISimpleEnumerator::iterator]
    1:  JavaScript error: resource:///modules/DBViewWrapper.jsm, line 1113: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgDBView.open]
    1:  JavaScript error: resource:///modules/AddrBookCard.jsm, line 196: NS_ERROR_NOT_AVAILABLE:
    1:  JavaScript error: chrome://mochitests/content/browser/comm/mail/test/browser/notification/browser_notification.js, line 60: NS_ERROR_FAILURE:

Without fixing these, the tests are not supposed to perform the expected testing since Javascript tests end prematurely (I think).
Some errors may be "expected" type, but I am not sure. But, if so, the particular test in question should print out "such and such errors are expected from this test. Please ignore them." for long-term maintenance reasons.

The number at the beginning of the following lines is the number of occurrences of the error.

TIA

Comment 1

[ISHIKAWA, Chiaki]

I forgot to mention that some, bugzilla entries have been filed.
JavaScript error: chrome://messenger/content/customizableui/panelUI.js, line 1346: TypeError: can't access property "firstChild", container is undefined
The above is Bug 1635019

20: JavaScript warning: resource://gre/modules/Troubleshoot.jsm, line 626: WebGL context was lost.
17: JavaScript error: chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js, line 483: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgMessageService.messageURIToMsgHdr]
7: JavaScript error: resource:///modules/activity/alertHook.jsm, line 49: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgMailNewsUrl.server]
4: JavaScript error: resource://testing-common/BrowserTestUtilsChild.jsm, line 267: TypeError: can't access property "href", aEvent.target.location is undefined
3: JavaScript error: chrome://messenger/content/messengercompose/MsgComposeCommands.js, line 5257: TypeError: can't access property "key", gCurrentIdentity is null
2: JavaScript error: chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js, line 483: NS_ERROR_FACTORY_NOT_REGISTERED: Component returned failure code: 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED) [nsIMessenger.messageServiceFromURI]
The above bug is Bug 1635648.

2:  JavaScript error: chrome://messenger/content/folderDisplay.js, line 1930: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgDBView.doCommand]
1:  JavaScript error: resource://services-settings/IDBHelpers.jsm, line 24: Error: IndexedDB: security-state/cert-revocations list() IndexedDB:  execute() The application is shutting down
1:  JavaScript error: resource://gre/modules/LoginHelper.jsm, line 1192: NS_ERROR_FAILURE: This login already exists.
1:  JavaScript error: resource://gre/modules/IMIncomingServer.jsm, line 165: TypeError: can't access property "setBool", this.imAccount is null
1:  JavaScript error: resource:///modules/imXPCOMUtils.jsm, line 272: TypeError: can't access property "values", this._items is undefined
1:  JavaScript error: resource:///modules/OTRUI.jsm, line 229: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "can't access property "values", this._items is undefined" {file: "resource:///modules/imXPCOMUtils.jsm" line: 272}]'[JavaScript Error: "can't access property "values", this._items is undefined" {file: "resource:///modules/imXPCOMUtils.jsm" line: 272}]' when calling method: [nsISimpleEnumerator::iterator]
1:  JavaScript error: resource:///modules/DBViewWrapper.jsm, line 1113: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgDBView.open]
1:  JavaScript error: resource:///modules/AddrBookCard.jsm, line 196: NS_ERROR_NOT_AVAILABLE:
1:  JavaScript error: chrome://mochitests/content/browser/comm/mail/test/browser/notification/browser_notification.js, line 60: NS_ERROR_FAILURE:

All right, many more bugzilla entries to file...

Comment 2

[Wayne Mery (:wsmwk)]

This bug has no blocking bugs which is unusual for a meta bug
Can it be covered in another bug, or be a non-meta bug blocking a different meta bug?

Comment 3

[ISHIKAWA, Chiaki]

Let me get this sorted out.
If I file a bugzilla for each errors (say from the top 10 list, based on the frequency of errors that are in mochitest or xpcshell tests, those errors will block this entry, correct?

I am running C-C TB mochitest locally using the ASAN version and upload the list of, say, JavaScript errors.
Then I will check if they have been filed (quite likely they are, if they appear on tryserver jobs).
If not, I will file a bugzilla for that error and make it block this entry.
But I am not clearing my needinfo request so that I won't forget to do so.

Comment 4

[ISHIKAWA, Chiaki]

(In reply to ISHIKAWA, Chiaki from comment #3)

Let me get this sorted out.
If I file a bugzilla for each errors (say from the top 10 list, based on the frequency of errors that are in mochitest or xpcshell tests, those errors will block this entry, correct?

I am running C-C TB mochitest locally using the ASAN version and upload the list of, say, JavaScript errors.
Then I will check if they have been filed (quite likely they are, if they appear on tryserver jobs).
If not, I will file a bugzilla for that error and make it block this entry.
But I am not clearing my needinfo request so that I won't forget to do so.

This is from today's run:
I only list errors that happen more than 2 times although there are many errors that happen twice or once.
The order is sorted by the frequency of occurrences.

*    65 Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "about:blank" line: 0}]
-     47 Console message: [JavaScript Warning: "Mixed Content: Upgrading insecure display request ‘http://mochi.test:8888/favicon.ico’ to use ‘https’" {file: "http://mochi.test:8888/favicon.ico" line: 0}]
     24 Console message: [JavaScript Warning: "WebGL context was lost." {file: "resource://gre/modules/Troubleshoot.sys.mjs" line: 762}]
     13 Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "chrome://messenger/content/aboutMessage.js" line: 301}]
*    10 Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "chrome://global/content/print.html" line: 0}]
      8 Console message: [JavaScript Error: "TypeError: can't access property "selectEventsSuppressed", gDBView.selection is null" {file: "chrome://messenger/content/aboutMessage.js" line: 232}]
      8 Console message: [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgSendLater.hasUnsentMessages]" {file: "chrome://messenger/content/mail-offline.js" line: 86}]
      7 Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“v” modifiers=“accel,alt” id=“”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1673}]
-     6 Console message: [JavaScript Warning: "Mixed Content: Upgrading insecure display request ‘http://mochi.test:8888/browser/comm/mail/components/extensions/test/browser/data/tb-logo.png’ to use ‘https’" {file: "http://mochi.test:8888/browser/comm/mail/components/extensions/test/browser/data/tb-logo.png" line: 0}]
*     4 Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "chrome://global/content/elements/browser-custom-element.js" line: 948}]
      4 Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: Assert failed: [CalCalendarManager::registerCalendar] calendar already registered!
*     3 Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "chrome://messenger/content/mailWindow.js" line: 56}]
      3 Console message: [JavaScript Error: "TypeError: URL constructor: null is not a valid URL." {file: "resource://gre/modules/LoginManagerParent.sys.mjs" line: 155}]

Lines marked with "*" at the beggining of the line are related to the flashing issue before the page is fully loaded.
Lines marked with "-" are related to the use of http: as opposed to https:

I will analyze the remaining errors hopefully later today.
Not many errors remain in the above list. So I may have to list and look into errors that happen only twice or once during mochitest.
There are MANY of them, and I may have to re-classify some of them into a single classification entry. More on this later.

Comment 5

[ISHIKAWA, Chiaki]

Sorry, I am now tied up with some urgent deadlines for my day job, and so this may have to wait.

Comment 6

[ISHIKAWA, Chiaki]

In the meantime, I now realize that there are some other errors reported using console.error and they have to be taken care of as well.
Bug 1635029